github/Discord.Net
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Clean up attribute checking and extraneous casts

Browse Source 
This probably isn't all of them. This is what I get for copy+pasting code.
This commit is contained in:
FiniteReality
2016-11-18 09:24:31 +00:00
parent de645548a9
commit 196cce05af
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/Discord.Net.Commands/Utilities/ModuleClassBuilder.cs
View File

@@ -91,8 +91,9 @@ namespace Discord.Commands
builder.AddAliases((attribute as AliasAttribute).Aliases); builder.AddAliases((attribute as AliasAttribute).Aliases);
else if (attribute is GroupAttribute) else if (attribute is GroupAttribute)
{ {
builder.Name = builder.Name ?? (attribute as GroupAttribute).Prefix; var groupAttr = attribute as GroupAttribute;
builder.AddAliases((attribute as GroupAttribute).Prefix); builder.Name = builder.Name ?? groupAttr.Prefix;
builder.AddAliases(groupAttr.Prefix);
} }
else if (attribute is PreconditionAttribute) else if (attribute is PreconditionAttribute)
builder.AddPrecondition(attribute as PreconditionAttribute); builder.AddPrecondition(attribute as PreconditionAttribute);
@@ -132,8 +133,6 @@ namespace Discord.Commands
builder.Remarks = (attribute as RemarksAttribute).Text; builder.Remarks = (attribute as RemarksAttribute).Text;
else if (attribute is AliasAttribute) else if (attribute is AliasAttribute)
builder.AddAliases((attribute as AliasAttribute).Aliases); builder.AddAliases((attribute as AliasAttribute).Aliases);
else if (attribute is GroupAttribute)
builder.AddAliases((attribute as GroupAttribute).Prefix);
else if (attribute is PreconditionAttribute) else if (attribute is PreconditionAttribute)
builder.AddPrecondition(attribute as PreconditionAttribute); builder.AddPrecondition(attribute as PreconditionAttribute);
} }