Replaced several arrays with immutables

src/Discord.Net.Commands/CommandService.cs

@@ -213,12 +213,12 @@ namespace Discord.Commands
                 {
                     if (parseResult.Error == CommandError.MultipleMatches)
                     {
-                        TypeReaderValue[] argList, paramList;
+                        IReadOnlyList<TypeReaderValue> argList, paramList;
                         switch (multiMatchHandling)
                         {
                             case MultiMatchHandling.Best:
-                                argList = parseResult.ArgValues.Select(x => x.Values.OrderByDescending(y => y.Score).First()).ToArray();
+                                argList = parseResult.ArgValues.Select(x => x.Values.OrderByDescending(y => y.Score).First()).ToImmutableArray();
-                                paramList = parseResult.ParamValues.Select(x => x.Values.OrderByDescending(y => y.Score).First()).ToArray();
+                                paramList = parseResult.ParamValues.Select(x => x.Values.OrderByDescending(y => y.Score).First()).ToImmutableArray();
                                 parseResult = ParseResult.FromSuccess(argList, paramList);
                                 break;
                         }

src/Discord.Net.Commands/Readers/UserTypeReader.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.Collections.Immutable;
 using System.Globalization;
 using System.Linq;
 using System.Threading.Tasks;
@@ -74,7 +75,7 @@ namespace Discord.Commands
             }
 
             if (results.Count > 0)
-                return TypeReaderResult.FromSuccess(results.Values.ToArray());
+                return TypeReaderResult.FromSuccess(results.Values.ToImmutableArray());
             return TypeReaderResult.FromError(CommandError.ObjectNotFound, "User not found.");
         }
 

src/Discord.Net.Core/API/DiscordRestApiClient.cs

@@ -832,7 +832,7 @@ namespace Discord.API
             Preconditions.NotNull(args, nameof(args));
             options = RequestOptions.CreateOrClone(options);
 
-            var roles = args.ToArray();
+            var roles = args.ToImmutableArray();
             switch (roles.Length)
             {
                 case 0:

src/Discord.Net.Rest/Entities/Channels/RestGuildChannel.cs

@@ -15,11 +15,11 @@ namespace Discord.Rest
         public IReadOnlyCollection<Overwrite> PermissionOverwrites => _overwrites;
 
         internal IGuild Guild { get; }
-        public ulong GuildId => Guild.Id;
-
         public string Name { get; private set; }
         public int Position { get; private set; }
 
+        public ulong GuildId => Guild.Id;
+
         internal RestGuildChannel(BaseDiscordClient discord, IGuild guild, ulong id)
             : base(discord, id)
         {

src/Discord.Net.Rest/Entities/Guilds/RestGuildIntegration.cs

@@ -17,7 +17,6 @@ namespace Discord.Rest
         public bool IsSyncing { get; private set; }
         public ulong ExpireBehavior { get; private set; }
         public ulong ExpireGracePeriod { get; private set; }
-
         public ulong GuildId { get; private set; }
         public ulong RoleId { get; private set; }
         public RestUser User { get; private set; }

src/Discord.Net.Rest/Entities/Invites/RestInvite.cs

@@ -9,7 +9,6 @@ namespace Discord.Rest
     {
         public string ChannelName { get; private set; }
         public string GuildName { get; private set; }
-
         public ulong ChannelId { get; private set; }
         public ulong GuildId { get; private set; }
 

src/Discord.Net.Rest/Entities/Messages/RestMessage.cs

@@ -19,7 +19,6 @@ namespace Discord.Rest
         public virtual bool IsPinned => false;
         public virtual bool IsWebhook => false;
         public virtual DateTimeOffset? EditedTimestamp => null;
-
         public virtual IReadOnlyCollection<IAttachment> Attachments => ImmutableArray.Create<IAttachment>();
         public virtual IReadOnlyCollection<IEmbed> Embeds => ImmutableArray.Create<IEmbed>();
         public virtual IReadOnlyCollection<ulong> MentionedChannelIds => ImmutableArray.Create<ulong>();

src/Discord.Net.Rest/Entities/Messages/RestUserMessage.cs

@@ -25,7 +25,6 @@ namespace Discord.Rest
         public override bool IsPinned => _isPinned;
         public override bool IsWebhook => WebhookId != null;
         public override DateTimeOffset? EditedTimestamp => DateTimeUtils.FromTicks(_editedTimestampTicks);
-
         public override IReadOnlyCollection<IAttachment> Attachments => _attachments;
         public override IReadOnlyCollection<IEmbed> Embeds => _embeds;
         public override IReadOnlyCollection<ulong> MentionedChannelIds => _mentionedChannelIds;

src/Discord.Net.Rest/Entities/Roles/RestRole.cs

@@ -10,7 +10,6 @@ namespace Discord.Rest
     public class RestRole : RestEntity<ulong>, IRole
     {
         public RestGuild Guild { get; }
-
         public Color Color { get; private set; }
         public bool IsHoisted { get; private set; }
         public bool IsManaged { get; private set; }

src/Discord.Net.Rest/Entities/Users/RestConnection.cs

@@ -12,7 +12,6 @@ namespace Discord
         public string Type { get; }
         public string Name { get; }
         public bool IsRevoked { get; }
-
         public IReadOnlyCollection<ulong> IntegrationIds { get; }
 
         internal RestConnection(string id, string type, string name, bool isRevoked, IReadOnlyCollection<ulong> integrationIds)

src/Discord.Net.WebSocket/API/Gateway/RequestMembersParams.cs

@@ -14,8 +14,6 @@ namespace Discord.API.Gateway
         public int Limit { get; set; }
 
         [JsonProperty("guild_id")]
-        private ulong[] _guildIds { get; set; }
+        private ulong[] GuildIds { get; set; }
-        public IEnumerable<ulong> GuildIds { set { _guildIds = value.ToArray(); } }
-        public IEnumerable<IGuild> Guilds { set { _guildIds = value.Select(x => x.Id).ToArray(); } }
     }
 }

src/Discord.Net.WebSocket/DiscordSocketClient.cs

@@ -404,11 +404,11 @@ namespace Discord.WebSocket
             => DownloadUsersAsync(guilds.Select(x => x as SocketGuild).Where(x => x != null));
         private async Task DownloadUsersAsync(IEnumerable<SocketGuild> guilds)
         {
-            var cachedGuilds = guilds.ToArray();
+            var cachedGuilds = guilds.ToImmutableArray();
             if (cachedGuilds.Length == 0) return;
 
             //Wait for unsynced guilds to sync first.
-            var unsyncedGuilds = guilds.Select(x => x.SyncPromise).Where(x => !x.IsCompleted).ToArray();
+            var unsyncedGuilds = guilds.Select(x => x.SyncPromise).Where(x => !x.IsCompleted).ToImmutableArray();
             if (unsyncedGuilds.Length > 0)
                 await Task.WhenAll(unsyncedGuilds);
 
@@ -1565,7 +1565,7 @@ namespace Discord.WebSocket
         }
         private async Task SyncGuildsAsync()
         {
-            var guildIds = Guilds.Where(x => !x.IsSynced).Select(x => x.Id).ToArray();
+            var guildIds = Guilds.Where(x => !x.IsSynced).Select(x => x.Id).ToImmutableArray();
             if (guildIds.Length > 0)
                 await ApiClient.SendGuildSyncAsync(guildIds).ConfigureAwait(false);
         }