Remove generic exceptions. (#2913)

* Replace instances of Exception with better ones in reflection utils.

* Replace instances of Exception with better ones in the websocket project.

* Finish replacing generic exceptions.

* Tiny tweak to reflection utils for consistency with the .NET library.
This commit is contained in:
Nora
2024-05-11 22:23:08 +02:00
committed by GitHub
parent 83fdc8917e
commit 54d2fe5773
10 changed files with 22 additions and 18 deletions

View File

@@ -37,7 +37,7 @@ namespace Discord.Commands
}
catch (Exception ex)
{
throw new Exception($"Failed to create \"{ownerType.FullName}\".", ex);
throw new TargetInvocationException($"Failed to create \"{ownerType.FullName}\".", ex);
}
}
@@ -45,7 +45,7 @@ namespace Discord.Commands
{
var constructors = ownerType.DeclaredConstructors.Where(x => !x.IsStatic).ToArray();
if (constructors.Length == 0)
throw new InvalidOperationException($"No constructor found for \"{ownerType.FullName}\".");
throw new MissingMethodException($"No constructor found for \"{ownerType.FullName}\".");
else if (constructors.Length > 1)
throw new InvalidOperationException($"Multiple constructors found for \"{ownerType.FullName}\".");
return constructors[0];