Improved cache locking, removed manual timeout for Login()

src/Discord.Net/Collections/AsyncCollection.cs

@@ -9,7 +9,7 @@ namespace Discord.Collections
 	public abstract class AsyncCollection<TValue> : IEnumerable<TValue>
 		where TValue : class
 	{
-		private static readonly object _writerLock = new object();
+		private readonly object _writerLock;
 
 		internal class CollectionItemEventArgs : EventArgs
 		{
@@ -53,9 +53,10 @@ namespace Discord.Collections
 		protected readonly DiscordClient _client;
 		protected readonly ConcurrentDictionary<string, TValue> _dictionary;
 
-		protected AsyncCollection(DiscordClient client)
+		protected AsyncCollection(DiscordClient client, object writerLock)
 		{
 			_client = client;
+			_writerLock = writerLock;
 			_dictionary = new ConcurrentDictionary<string, TValue>();
 		}
 

src/Discord.Net/Collections/Channels.cs

@@ -6,8 +6,8 @@ namespace Discord.Collections
 {
     public sealed class Channels : AsyncCollection<Channel>
     {
-		internal Channels(DiscordClient client)
+		internal Channels(DiscordClient client, object writerLock)
-			: base(client) { }
+			: base(client, writerLock) { }
 
 		internal Channel GetOrAdd(string id, string serverId, string recipientId = null) => GetOrAdd(id, () => new Channel(_client, id, serverId, recipientId));
 		internal new Channel TryRemove(string id) => base.TryRemove(id);

src/Discord.Net/Collections/Members.cs

@@ -6,8 +6,8 @@ namespace Discord.Collections
 {
     public sealed class Members : AsyncCollection<Member>
 	{
-		internal Members(DiscordClient client)
+		internal Members(DiscordClient client, object writerLock)
-			: base(client) { }
+			: base(client, writerLock) { }
 
 		private string GetKey(string userId, string serverId) => serverId + '_' + userId;
 

src/Discord.Net/Collections/Messages.cs

@@ -5,8 +5,8 @@ namespace Discord.Collections
     public sealed class Messages : AsyncCollection<Message>
 	{
 		private readonly MessageCleaner _msgCleaner;
-		internal Messages(DiscordClient client)
+		internal Messages(DiscordClient client, object writerLock)
-			: base(client)
+			: base(client, writerLock)
 		{
 			_msgCleaner = new MessageCleaner(client);
         }

src/Discord.Net/Collections/Roles.cs

@@ -6,8 +6,8 @@ namespace Discord.Collections
 {
     public sealed class Roles : AsyncCollection<Role>
 	{
-		internal Roles(DiscordClient client)
+		internal Roles(DiscordClient client, object writerLock)
-			: base(client) { }
+			: base(client, writerLock) { }
 
 		internal Role GetOrAdd(string id, string serverId) => GetOrAdd(id, () => new Role(_client, id, serverId));
 		internal new Role TryRemove(string id) => base.TryRemove(id);

src/Discord.Net/Collections/Servers.cs

@@ -6,8 +6,8 @@ namespace Discord.Collections
 {
     public sealed class Servers : AsyncCollection<Server>
 	{
-		internal Servers(DiscordClient client)
+		internal Servers(DiscordClient client, object writerLock)
-			: base(client) { }
+			: base(client, writerLock) { }
 
 		internal Server GetOrAdd(string id) => base.GetOrAdd(id, () => new Server(_client, id));
 		internal new Server TryRemove(string id) => base.TryRemove(id);

src/Discord.Net/Collections/Users.cs

@@ -6,8 +6,8 @@ namespace Discord.Collections
 {
 	public sealed class Users : AsyncCollection<User>
 	{
-		internal Users(DiscordClient client)
+		internal Users(DiscordClient client, object writerLock)
-			: base(client) { }
+			: base(client, writerLock) { }
 
 		internal User GetOrAdd(string id) => GetOrAdd(id, () => new User(_client, id));
 		internal new User TryRemove(string id) => base.TryRemove(id);

src/Discord.Net/DiscordClient.cs

@@ -136,12 +136,13 @@ namespace Discord
 				};
             }
 
-			_channels = new Channels(this);
+			object cacheLock = new object();
-			_members = new Members(this);
+			_channels = new Channels(this, cacheLock);
-			_messages = new Messages(this);
+			_members = new Members(this, cacheLock);
-			_roles = new Roles(this);
+			_messages = new Messages(this, cacheLock);
-			_servers = new Servers(this);
+			_roles = new Roles(this, cacheLock);
-			_users = new Users(this);
+			_servers = new Servers(this, cacheLock);
+			_users = new Users(this, cacheLock);
 
 			_dataSocket.LogMessage += (s, e) => RaiseOnLog(e.Severity, LogMessageSource.DataWebSocket, e.Message);
 			if (_config.EnableVoice)
@@ -645,9 +646,6 @@ namespace Discord
 			string token;
 			try
 			{
-				var cancelToken = new CancellationTokenSource();
-				cancelToken.CancelAfter(5000);
-				_api.CancelToken = cancelToken.Token;
 				var response = await _api.Login(email, password).ConfigureAwait(false);
 				token = response.Token;
                 if (_config.LogLevel >= LogMessageSeverity.Verbose)