Remove analyzer project & resolve some build warnings (#2905)

* yeet analyzer & analyzer test

* fix test warning

* yeet analyzer from the workflow

* resolve more warnings

* forgot to push

samples/InteractionFramework/InteractionHandler.cs

@@ -39,8 +39,11 @@ public class InteractionHandler
         _handler.InteractionExecuted += HandleInteractionExecute;
     }
 
-    private async Task LogAsync(LogMessage log)
-        => Console.WriteLine(log);
+    private Task LogAsync(LogMessage log)
+    {
+        Console.WriteLine(log);
+        return Task.CompletedTask;
+    }
 
     private async Task ReadyAsync()
     {
@@ -80,7 +83,7 @@ public class InteractionHandler
         }
     }
 
-    private async Task HandleInteractionExecute(ICommandInfo commandInfo, IInteractionContext context, IResult result)
+    private Task HandleInteractionExecute(ICommandInfo commandInfo, IInteractionContext context, IResult result)
     {
         if (!result.IsSuccess)
             switch (result.Error)
@@ -91,5 +94,7 @@ public class InteractionHandler
                 default:
                     break;
             }
+
+        return Task.CompletedTask;
     }
 }

samples/InteractionFramework/Modules/ExampleModule.cs

@@ -61,7 +61,7 @@ public class ExampleModule : InteractionModuleBase<SocketInteractionContext>
     // Select Menu interactions, contain ids of the menu options that were selected by the user. You can access the option ids from the method parameters.
     // You can also use the wild card pattern with Select Menus, in that case, the wild card captures will be passed on to the method first, followed by the option ids.
     [ComponentInteraction("roleSelect")]
-    public async Task RoleSelect(string[] selections)
+    public Task RoleSelect(string[] selections)
     {
         throw new NotImplementedException();
     }

samples/InteractionFramework/Program.cs

@@ -59,6 +59,9 @@ public class Program
         await Task.Delay(Timeout.Infinite);
     }
 
-    private static async Task LogAsync(LogMessage message)
-        => Console.WriteLine(message.ToString());
+    private static Task LogAsync(LogMessage message)
+    {
+        Console.WriteLine(message.ToString());
+        return Task.CompletedTask;
+    }
 }