From 8d5022acb8cf6842cd3a492fa37ac1b6fcd58c5b Mon Sep 17 00:00:00 2001 From: Markus Oppmann <71436559+MaxEtMoritz@users.noreply.github.com> Date: Sat, 18 Nov 2023 21:51:54 +0100 Subject: [PATCH] Fix Slash Command Localizations lost after AddCommandsToGuildAsync and deleteMissing = false (#2758) fetch localizations when adding commands with `deleteMissing` = `false` fixes #2757 --- src/Discord.Net.Interactions/InteractionService.cs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/Discord.Net.Interactions/InteractionService.cs b/src/Discord.Net.Interactions/InteractionService.cs index fd02887b..fd5747d6 100644 --- a/src/Discord.Net.Interactions/InteractionService.cs +++ b/src/Discord.Net.Interactions/InteractionService.cs @@ -392,7 +392,7 @@ namespace Discord.Interactions if (!deleteMissing) { - var existing = await RestClient.GetGuildApplicationCommands(guildId).ConfigureAwait(false); + var existing = await RestClient.GetGuildApplicationCommands(guildId, true).ConfigureAwait(false); var missing = existing.Where(x => !props.Any(y => y.Name.IsSpecified && y.Name.Value == x.Name)); props.AddRange(missing.Select(x => x.ToApplicationCommandProps())); } @@ -416,7 +416,7 @@ namespace Discord.Interactions if (!deleteMissing) { - var existing = await RestClient.GetGlobalApplicationCommands().ConfigureAwait(false); + var existing = await RestClient.GetGlobalApplicationCommands(true).ConfigureAwait(false); var missing = existing.Where(x => !props.Any(y => y.Name.IsSpecified && y.Name.Value == x.Name)); props.AddRange(missing.Select(x => x.ToApplicationCommandProps())); } @@ -481,7 +481,7 @@ namespace Discord.Interactions if (!deleteMissing) { - var existing = await RestClient.GetGuildApplicationCommands(guildId).ConfigureAwait(false); + var existing = await RestClient.GetGuildApplicationCommands(guildId, true).ConfigureAwait(false); var missing = existing.Where(x => !props.Any(y => y.Name.IsSpecified && y.Name.Value == x.Name)); props.AddRange(missing.Select(x => x.ToApplicationCommandProps())); } @@ -523,7 +523,7 @@ namespace Discord.Interactions if (!deleteMissing) { - var existing = await RestClient.GetGuildApplicationCommands(guildId).ConfigureAwait(false); + var existing = await RestClient.GetGuildApplicationCommands(guildId, true).ConfigureAwait(false); var missing = existing.Where(x => !props.Any(y => y.Name.IsSpecified && y.Name.Value == x.Name)); props.AddRange(missing.Select(x => x.ToApplicationCommandProps())); } @@ -547,7 +547,7 @@ namespace Discord.Interactions if (!deleteMissing) { - var existing = await RestClient.GetGlobalApplicationCommands().ConfigureAwait(false); + var existing = await RestClient.GetGlobalApplicationCommands(true).ConfigureAwait(false); var missing = existing.Where(x => !props.Any(y => y.Name.IsSpecified && y.Name.Value == x.Name)); props.AddRange(missing.Select(x => x.ToApplicationCommandProps())); } @@ -590,7 +590,7 @@ namespace Discord.Interactions if (!deleteMissing) { - var existing = await RestClient.GetGlobalApplicationCommands().ConfigureAwait(false); + var existing = await RestClient.GetGlobalApplicationCommands(true).ConfigureAwait(false); var missing = existing.Where(x => !props.Any(y => y.Name.IsSpecified && y.Name.Value == x.Name)); props.AddRange(missing.Select(x => x.ToApplicationCommandProps())); }