Task.Delay(0) => Task.CompletedTask (#3049)

src/Discord.Net.WebSocket/Audio/Streams/BufferedWriteStream.cs

@@ -187,7 +187,7 @@ namespace Discord.Audio.Streams
             do
                 cancelToken.ThrowIfCancellationRequested();
             while (_queuedFrames.TryDequeue(out _));
-            return Task.Delay(0);
+            return Task.CompletedTask;
         }
     }
 }

src/Discord.Net.WebSocket/Audio/Streams/InputStream.cs

@@ -76,7 +76,7 @@ namespace Discord.Audio.Streams
             if (_signal.CurrentCount >= MaxFrames) //1-2 seconds
             {
                 _hasHeader = false;
-                return Task.Delay(0); //Buffer overloaded
+                return Task.CompletedTask; //Buffer overloaded
             }
             if (!_hasHeader)
                 throw new InvalidOperationException("Received payload without an RTP header");
@@ -91,7 +91,7 @@ namespace Discord.Audio.Streams
                 payload: payload
             ));
             _signal.Release();
-            return Task.Delay(0);
+            return Task.CompletedTask;
         }
 
         protected override void Dispose(bool isDisposing)

src/Discord.Net.WebSocket/Audio/Streams/JitterBuffer.cs

@@ -240,7 +240,7 @@ namespace Discord.Audio.Streams
             do
                 cancelToken.ThrowIfCancellationRequested();
             while (_queuedFrames.TryDequeue(out Frame ignored));
-            return Task.Delay(0);
+            return Task.CompletedTask;
         }
     }
 }*/

src/Discord.Net.WebSocket/DiscordShardedClient.cs

@@ -428,7 +428,7 @@ namespace Discord.WebSocket
                     //Should only happen if token is changed
                     var _ = LogoutAsync(); //Signal the logout, fire and forget
                 }
-                return Task.Delay(0);
+                return Task.CompletedTask;
             };
 
             client.SentRequest += (method, endpoint, millis) => _sentRequest.InvokeAsync(method, endpoint, millis);

src/Discord.Net.WebSocket/DiscordSocketClient.cs

@@ -200,7 +200,7 @@ namespace Discord.WebSocket
                 {
                     var _ = g.DownloadUsersAsync();
                 }
-                return Task.Delay(0);
+                return Task.CompletedTask;
             };
 
             _largeGuilds = new ConcurrentQueue<ulong>();

src/Discord.Net.WebSocket/Entities/Guilds/SocketGuild.cs

@@ -1793,7 +1793,7 @@ namespace Discord.WebSocket
                     audioClient.Connected += () =>
                     {
                         _ = promise.TrySetResultAsync(_audioClient);
-                        return Task.Delay(0);
+                        return Task.CompletedTask;
                     };
 
                     _audioClient = audioClient;

src/Discord.Net.WebSocket/Net/DefaultUdpSocket.cs

@@ -92,7 +92,7 @@ namespace Discord.Net.Udp
             catch { }
 
             if (!isDisposing)
-                await (_task ?? Task.Delay(0)).ConfigureAwait(false);
+                await (_task ?? Task.CompletedTask).ConfigureAwait(false);
 
             if (_udp != null)
             {

src/Discord.Net.WebSocket/Net/DefaultWebSocketClient.cs

@@ -140,7 +140,7 @@ namespace Discord.Net.WebSockets
 
             try
             {
-                await (_task ?? Task.Delay(0)).ConfigureAwait(false);
+                await (_task ?? Task.CompletedTask).ConfigureAwait(false);
                 _task = null;
             }
             finally { _isDisconnecting = false; }