Make module service scopes optional (#1997)

Co-Authored-By: Cenk Ergen <57065323+Cenngo@users.noreply.github.com>

src/Discord.Net.Interactions/Info/Commands/CommandInfo.cs

@@ -130,15 +130,25 @@ namespace Discord.Interactions
             switch (RunMode)
             {
                 case RunMode.Sync:
+                    {
+                        if (CommandService._autoServiceScopes)
                         {
                             using var scope = services?.CreateScope();
                             return await ExecuteInternalAsync(context, args, scope?.ServiceProvider ?? EmptyServiceProvider.Instance).ConfigureAwait(false);
                         }
+                        else
+                            return await ExecuteInternalAsync(context, args, services).ConfigureAwait(false);
+                    }
                 case RunMode.Async:
                     _ = Task.Run(async () =>
+                    {
+                        if (CommandService._autoServiceScopes)
                         {
                             using var scope = services?.CreateScope();
                             await ExecuteInternalAsync(context, args, scope?.ServiceProvider ?? EmptyServiceProvider.Instance).ConfigureAwait(false);
+                        }
+                        else
+                            await ExecuteInternalAsync(context, args, services).ConfigureAwait(false);
                     });
                     break;
                 default:

src/Discord.Net.Interactions/InteractionService.cs

@@ -67,7 +67,7 @@ namespace Discord.Interactions
         internal readonly LogManager _logManager;
         internal readonly Func<DiscordRestClient> _getRestClient;
 
-        internal readonly bool _throwOnError, _useCompiledLambda, _enableAutocompleteHandlers;
+        internal readonly bool _throwOnError, _useCompiledLambda, _enableAutocompleteHandlers, _autoServiceScopes;
         internal readonly string _wildCardExp;
         internal readonly RunMode _runMode;
         internal readonly RestResponseCallback _restResponseCallback;
@@ -156,6 +156,7 @@ namespace Discord.Interactions
             _wildCardExp = config.WildCardExpression;
             _useCompiledLambda = config.UseCompiledLambda;
             _enableAutocompleteHandlers = config.EnableAutocompleteHandlers;
+            _autoServiceScopes = config.AutoServiceScopes;
             _restResponseCallback = config.RestResponseCallback;
 
             _genericTypeConverters = new ConcurrentDictionary<Type, Type>

src/Discord.Net.Interactions/InteractionServiceConfig.cs

@@ -47,6 +47,11 @@ namespace Discord.Interactions
         /// </remarks>
         public bool EnableAutocompleteHandlers { get; set; } = true;
 
+        /// <summary>
+        ///     Gets or sets whether new service scopes should be automatically created when resolving module depedencies on every command execution.
+        /// </summary>
+        public bool AutoServiceScopes { get; set; } = true;
+
         /// <summary>
         ///     Gets or sets delegate to be used by the <see cref="InteractionService"/> when responding to a Rest based interaction.
         /// </summary>