feature: Make bidirectional formatting optional (#2204)

* Init

* Clearing up comment on config entry.

* Update user entities to remove storage of the setting

Co-authored-by: Quin Lynch <lynchquin@gmail.com>

src/Discord.Net.Rest/BaseDiscordClient.cs

@@ -36,6 +36,7 @@ namespace Discord.Rest
         /// <inheritdoc />
         public TokenType TokenType => ApiClient.AuthTokenType;
         internal bool UseInteractionSnowflakeDate { get; private set; }
+        internal bool FormatUsersInBidirectionalUnicode { get; private set; }
 
         /// <summary> Creates a new REST-only Discord client. </summary>
         internal BaseDiscordClient(DiscordRestConfig config, API.DiscordRestApiClient client)
@@ -49,6 +50,7 @@ namespace Discord.Rest
             _isFirstLogin = config.DisplayInitialLog;
 
             UseInteractionSnowflakeDate = config.UseInteractionSnowflakeDate;
+            FormatUsersInBidirectionalUnicode = config.FormatUsersInBidirectionalUnicode;
 
             ApiClient.RequestQueue.RateLimitTriggered += async (id, info, endpoint) =>
             {

src/Discord.Net.Rest/Entities/Users/RestUser.cs

@@ -129,8 +129,10 @@ namespace Discord.Rest
         /// <returns>
         ///     A string that resolves to Username#Discriminator of the user.
         /// </returns>
-        public override string ToString() => Format.UsernameAndDiscriminator(this);
-        private string DebuggerDisplay => $"{Format.UsernameAndDiscriminator(this)} ({Id}{(IsBot ? ", Bot" : "")})";
+        public override string ToString()
+            => Format.UsernameAndDiscriminator(this, Discord.FormatUsersInBidirectionalUnicode);
+
+        private string DebuggerDisplay => $"{Format.UsernameAndDiscriminator(this, Discord.FormatUsersInBidirectionalUnicode)} ({Id}{(IsBot ? ", Bot" : "")})";
         #endregion
 
         #region IUser