Implemented IComparable<T> on IRole and IGuildUUser

src/Discord.Net.Core/Entities/Roles/IRole.cs

@@ -4,7 +4,7 @@ using System.Threading.Tasks;
 
 namespace Discord
 {
-    public interface IRole : ISnowflakeEntity, IDeletable, IMentionable
+    public interface IRole : ISnowflakeEntity, IDeletable, IMentionable, IComparable<IRole>
     {
         /// <summary> Gets the guild owning this role.</summary>
         IGuild Guild { get; }

src/Discord.Net.Core/Entities/Users/IGuildUser.cs

@@ -6,7 +6,7 @@ using System.Threading.Tasks;
 namespace Discord
 {
     /// <summary> A Guild-User pairing. </summary>
-    public interface IGuildUser : IUser, IVoiceState
+    public interface IGuildUser : IUser, IVoiceState, IComparable<IGuildUser>
     {
         /// <summary> Gets when this user joined this guild. </summary>
         DateTimeOffset? JoinedAt { get; }

src/Discord.Net.Core/Extensions/GuildUserExtensions.cs

@@ -15,5 +15,17 @@ namespace Discord
             => RemoveRolesAsync(user, (IEnumerable<IRole>)roles);
         public static Task RemoveRolesAsync(this IGuildUser user, IEnumerable<IRole> roles)
             => user.ModifyAsync(x => x.RoleIds = user.RoleIds.Except(roles.Select(y => y.Id)).ToArray());
+
+        public static IEnumerable<IRole> GetRoles(this IGuildUser user) {
+            var guild = user.Guild;
+            return user.RoleIds.Select(r => guild.GetRole(r));
+        }
+
+        internal static int Compare(this IGuildUser u1, IGuildUser u2) {
+            var r1 = u1.GetRoles().Max();
+            var r2 = u2.GetRoles().Max();
+            var result = r1.CompareTo(r2);
+            return result != 0 ? result : u1.Id.CompareTo(u2.Id);
+        }
     }
 }

src/Discord.Net.Rest/Entities/Roles/RestRole.cs

@@ -4,9 +4,7 @@ using System.Diagnostics;
 using System.Threading.Tasks;
 using Model = Discord.API.Role;
 
-namespace Discord.Rest
+namespace Discord.Rest { [DebuggerDisplay(@"{DebuggerDisplay,nq}")]
-{
-    [DebuggerDisplay(@"{DebuggerDisplay,nq}")]
     public class RestRole : RestEntity<ulong>, IRole
     {
         public RestGuild Guild { get; }
@@ -51,10 +49,12 @@ namespace Discord.Rest
         public Task DeleteAsync(RequestOptions options = null)
             => RoleHelper.DeleteAsync(this, Discord, options);
 
+
         public override string ToString() => Name;
         private string DebuggerDisplay => $"{Name} ({Id})";
 
         //IRole
         IGuild IRole.Guild => Guild;
+        public int CompareTo(IRole role) => Position.CompareTo(role.Position);
     }
 }

src/Discord.Net.Rest/Entities/Users/RestGuildUser.cs

@@ -97,11 +97,14 @@ namespace Discord.Rest
             }
         }
     
+        public int CompareTo(IGuildUser user) => this.Compare(user);
+
         //IVoiceState
         bool IVoiceState.IsSelfDeafened => false;
         bool IVoiceState.IsSelfMuted => false;
         bool IVoiceState.IsSuppressed => false;
         IVoiceChannel IVoiceState.VoiceChannel => null;
         string IVoiceState.VoiceSessionId => null;
+
     }
 }

src/Discord.Net.WebSocket/Entities/Roles/SocketRole.cs

@@ -57,5 +57,6 @@ namespace Discord.WebSocket
 
         //IRole
         IGuild IRole.Guild => Guild;
+        public int CompareTo(IRole role) => Position.CompareTo(role.Position);
     }
 }

src/Discord.Net.WebSocket/Entities/Users/SocketGuildUser.cs

@@ -96,6 +96,7 @@ namespace Discord.WebSocket
         IGuild IGuildUser.Guild => Guild;
         ulong IGuildUser.GuildId => Guild.Id;
         IReadOnlyCollection<ulong> IGuildUser.RoleIds => RoleIds;
+        public int CompareTo(IGuildUser user) => this.Compare(user);
 
         //IUser
         Task<IDMChannel> IUser.GetDMChannelAsync(CacheMode mode, RequestOptions options)