* Add XML docs
* Clean up style switcher
* Squash commits on branch docs/faq-n-patches
* Fix broken theme selector
* Add local image embed instruction
* Add a bunch of XML docs
* Add a bunch of XML docs
* Fix broken search
+ DocFX by default ships with an older version of jQuery, switching to a newer version confuses parts of the DocFX Javascript.
* Minor fixes for CONTRIBUTING.md and README.md
* Clean up filterConfig.yml
+ New config exposes Discord.Net namespace since it has several common public exceptions that may be helpful to users
* Add XML docs
* Read token from Environment Variable instead of hardcode
* Add XMLDocs
* Compress some assets & add OAuth2 URL generator
* Fix sample link & add missing pictures
* Add tag examples
* Fix embed docs consistency
* Add details regarding userbot support
* Add XML Docs
* Add XML Docs
* Add XML Docs
* Minor fixes in documentations
+ Fix unescaped '<'
+ Fix typo
* Fix seealso for preconditions and add missing descriptions
* Add missing exceptions
* Document exposed TypeReaders
* Fix letter-casing for files
* Add 'last modified' plugin
Source: https://github.com/Still34/DocFx.Plugin.LastModified
Licensed under MIT License
* XML Docs
* Fix minor consistencies & redundant impl
* Add properties examples to overwrite
* Fix missing Username prop
* Add warning for bulk-delete endpoint
* Replace note block
* Add BaseSocketClient docs
* Add XML docs
* Replace langword null to code block null instead
- Because DocFX sucks at rendering langword
* Replace all langword placements with code block
* Add more IGuild docs
* Add details to SpotifyGame
* Initial proofread of the articles
* Add explanation for RunMode
* Add event docs
- MessageReceived
- ChannelUpdated/Destroyed/Created
* Fix light theme link color
* Fix xml docs error
* Add partial documentation for audit log impl
* Add documentation for some REST-based objects
* Add partial documentation for audit log objects
* Add more XML comments to quotation mark alias map stuff, including an example
* Add reference to CommandServiceConfig from the util docs'
* Add explanation that if " is removed then it wont work
* Fix missing service provider in example
* Add documentation for new INestedChannel
* Add documentation
* Add documentation for new API version & few events
* Revise guide paragraphs/samples
+ Fix various formatting.
+ Provide a more detailed walkthrough for dependency injection.
+ Add C# note at intro.
* Fix typos & formatting
* Improve group module example
* Small amount to see if I'm doing it right
* Remove/cleanup redundant variables
* Fix EnterTypingState impl for doc inheritance
* Fix Test to resolve changes made in 15b58e
* Improve precondition documentation
+ Add precondition usage sample
+ Add precondition group usage sample
+ Move precondition samples to its own sample folder
* Move samples to individual folders
* Clarify token source
* Cleanup styling of README.md for docs
* Replace InvalidPathChars for NS1.3
* InvalidPathChars does not exist in NS1.3; replaced with GetInvalidPathChars instead.
* Add a missing change for 2c7cc738
* Update LastModified to v1.1.0 & add license
* Rewrite installation page for Core 2.1
* Fix anchor link
* Bump post-processor to v1.1.1
* Add fixes to partial file & add license
* Moved theme-switcher code to scripts partial file
+ Add author's MIT license to featherlight javascript
* Remove unused bootstrap plugin
* Bump LastModified plugin
* Changed the path from 'lastmodified' to 'last-modified' for consistency
* Cleanup README & Contribution guide
* Changes to last pr
* Fix GetCategoryAsync docs
* Proofread and cleanup articles
* Change passive voice in "Get Started" to active
* Fix improper preposition in Commands Introduction page
* Fix minor grammar mistakes in "Your First Bot" (future tense -> present tense/subjunctive mood -> indicative mood/proper noun casing/incorrect noun/add missing article)
* Fix minor grammar mistakes in "Installation" (missing article)
* no hablo ingles
* Try try try again
* I'm sure you're having as much fun as I am
* Cleanup TOC & fix titles
* Improve styling
+ Change title font to Noto Sans
+ Add materialized design for commit message box
* Add DescriptionGenerator plugin
* Add nightly section for clarification
* Fix typos in Nightlies & Post-execution
* Bump DescriptionGenerator to v1.1.0
+ This build adds the functionality of generating managed references' summary into the description tag.
* Initial emoji article draft
* Add 'additional information' section for emoji article
* Add cosmetic changes to the master css
* Alter info box color
+ Add transition to article content
* Add clarification in the emoji article
* Emphasize that normal emoji string will not translate to its Unicode representation.
* Clean up or add some of the samples featured in the article.
+ Add emoji/emote declaration section for clarification.
+ Add WebSocket emote sample.
- Remove inconsistent styling ('wacky memes' proves to be too out of place).
* Improve readability for nightlies article
* Move 'Bundled Preconditions' section
* Bump LastModified to fix UTC DateTime parsing
* Add langwordMapping.yml
* Add XML docs
* Add VSC workspace rule
* The root workspace limits the ruler to 120 characters for member documentations and excludes folders such as 'samples' and 'docs'.
* The docs workspace limits the ruler to 70 characters for standard conceptual article to comply with documentation's CONTRIBUTING.md rule, and excludes temprorary folders created by DocFX.
* Update CONTRIBUTING.md
* Add documentation style rule
* Fix styling of several member documentation
* Fix ' />' caused by Agent Smith oddities
* Fix styling to be more specific about the mention of IDs
* Fix exception summary to comply with official Microsoft Docs style
* References
https://docs.microsoft.com/en-us/dotnet/api/system.argumentnullexception?view=netframework-4.7.2
https://docs.microsoft.com/en-us/dotnet/api/system.platformnotsupportedexception?view=netframework-4.7.2
https://docs.microsoft.com/en-us/dotnet/api/system.badimageformatexception?view=netframework-4.7.2
* Add XML documentations
* Shift color return docs
* Fix minor docs
* Added documentation for SocketDMChannel, SocketGuildChannel, and SocketTextChannel
* Add XML docs
* Corrections to SocketGuildChannel
* Corrections to SocketTextChannel
* Corrections to SocketDMChannel
* Swapped out 'id' for 'snowflake identifier
* Swapped out 'id' for 'snowflake identifier'
* SocketDMChannel amendments
* SocketGuildChannel amendments
* SocketTextChannel amendments
* Add XML docs & patch return types
+ Starting from this commit, all return types for tasks will use style similar to most documentations featured on docs.microsoft.com
References:
https://docs.microsoft.com/en-us/dotnet/api/microsoft.entityframeworkcore.dbcontext.-ctor?view=efcore-2.1
https://docs.microsoft.com/en-us/dotnet/api/system.io.filestream.readasync?view=netcore-2.1
https://docs.microsoft.com/en-us/dotnet/api/system.io.textwriter.writelineasync?view=netcore-2.1#System_IO_TextWriter_WriteLineAsync_System_Char___
And many more other asynchronous method documentations featured in the latest BCL.
* Added documentation for many audit log data types, fixed vowel indefinite articles
* Change audit log data types to start with 'Contains' (verb) instead of an article
* Fix some documentation issues and document some more audit log data types
* Fix English posession
* Add XML doc
* Documented two more types
* Documented RoleCreateAuditLogData
* Document remaining audit log data types
* Added RestDMChannel documentation
* Added RestGuildChannel documentation
* Added RestTextChannel documentation
* Added RestVoiceChannel documentation
* Added RestUser documentation
* Added RestRole documentation
* Added RestMessage documentation
* Slightly better wording
* Contains -> Contains a piece of (describe article)
* [EN] Present perf. -> past perf.
* Add XML docs
* Fix arrow alignment
* Clarify supported nullable type
* Fixed a typo in ISnowflakeEntity
* Added RestUser Documentation
* Added RestInvite documentation
* Add XML docs & minor optimizations
* Minor optimization for doc rendering
* Rollback font optimization changes
* Amendments to RestUser
* Added SocketDMChannel documentation
* Added RestDMChannel documentation
* Added RestGuild documentation
* Adjustment to SocketDMChannel
* Added minimal descriptions from the API documentation for Integration types
* Added obsolete mention to the ReadMessages flag.
* Added remarks about 2FA requirement for guild permissions
* Added xmldoc for GuildPermission methods
* Added xml doc for ToAllowList and ToDenyList
* Added specification of how the bits of the color raw value are packed
* Added discord API documentation to IConnection interface
* I can spell :^)
* Fix whitespace in ChannelPermission
* fix spacing of values in guildpermission
* Made changes to get field descriptions from feedback, added returns tag to IConnection
* Added property get standard for IntegrationAccount
* Added property get pattern to xml docs and identical returns tag.
* Change all color class references to struct
...because it isn't a class.
* Add XML docs
* Rewrote the returns tags in IGuildIntegration, removed the ones I was unsure about.
* Rewrote the rest of the returns tags
* Amendments
* Cleanup doc for c1d78189
* Added types to <returns> tags where missing
* Added second sample for adding reactions
* Added some class summaries
* Missed a period
* Amendments
* restored the removed line break
* Removed unnecessary see tag
* Use consistent quotation marks around subscribers, the name for these users are dependant on the source of where they are integrated from (youtube or twitch), so we should not use a name that is specific to one platform
* Add <remarks> tag to the IGuildIntegration xmldocs
* Fix grammar issue
* Update DescriptionGenerator
* Cleanup of https://github.com/Still34/Discord.Net/pull/8
* Cleanup previous PR
* Fix for misleading behaviour in the emoji guide
+ Original lines stated that sending a emoji wrapped in colon will not be parsed, but that was incorrect; replaced with reactions instead of sending messages as the example
* Add strings for dictionary in DotSettings
* Add XML docs
* Fix lots of typos in comments
+ Geez, I didn't know there were so many.
* Add XML docs & rewrite GetMessagesAsync docs
This commit rewrites the remarks section of GetMessagesAsync, as well as adding examples to several methods.
* Update 'Your First Bot'
+ This commit reflects the new changes made to the Discord Application Developer Portal after its major update
* Initial optimization for DocFX render & add missing files
* Add examples in message methods
* Cleanup https://github.com/RogueException/Discord.Net/pull/1128
* Fix first bot note
* Cleanup FAQ structure
* Add XML docs
* Update docfx plugins
* Fix navbar collapsing issue
* Fix broken xref
* Cleanup FAQ section
+ Add introductory paragraphs to each FAQ section.
+ Add 'missing dependency' entry to commands FAQ.
* Split commands FAQ to 'General' and 'DI' sections.
* Cleanup https://github.com/RogueException/Discord.Net/pull/1139
* Fix missing namespace
* Add missing highlighting css for the light theme
* Add additional clarification for installing packages
* Add indentation to example for clarity
* Cleanup several articles to be more human-friendly and easier to read
* Remove RPC-related notes
* Cleanup slow-mode-related documentation strings
* Add an additional note about cross-guild emote usage
* Add CreateTextChannel sample
* Add XMLDocs
271 lines
13 KiB
C#
271 lines
13 KiB
C#
using System.Collections.Generic;
|
|
using System.Linq;
|
|
using System.Text;
|
|
using Microsoft.CodeAnalysis;
|
|
using Microsoft.CodeAnalysis.Diagnostics;
|
|
//using Microsoft.VisualStudio.TestTools.UnitTesting;
|
|
using Xunit;
|
|
|
|
namespace TestHelper
|
|
{
|
|
/// <summary>
|
|
/// Superclass of all Unit Tests for DiagnosticAnalyzers
|
|
/// </summary>
|
|
public abstract partial class DiagnosticVerifier
|
|
{
|
|
#region To be implemented by Test classes
|
|
/// <summary>
|
|
/// Get the CSharp analyzer being tested - to be implemented in non-abstract class
|
|
/// </summary>
|
|
protected virtual DiagnosticAnalyzer GetCSharpDiagnosticAnalyzer()
|
|
{
|
|
return null;
|
|
}
|
|
|
|
/// <summary>
|
|
/// Get the Visual Basic analyzer being tested (C#) - to be implemented in non-abstract class
|
|
/// </summary>
|
|
protected virtual DiagnosticAnalyzer GetBasicDiagnosticAnalyzer()
|
|
{
|
|
return null;
|
|
}
|
|
#endregion
|
|
|
|
#region Verifier wrappers
|
|
|
|
/// <summary>
|
|
/// Called to test a C# DiagnosticAnalyzer when applied on the single inputted string as a source
|
|
/// Note: input a DiagnosticResult for each Diagnostic expected
|
|
/// </summary>
|
|
/// <param name="source">A class in the form of a string to run the analyzer on</param>
|
|
/// <param name="expected"> DiagnosticResults that should appear after the analyzer is run on the source</param>
|
|
protected void VerifyCSharpDiagnostic(string source, params DiagnosticResult[] expected)
|
|
{
|
|
VerifyDiagnostics(new[] { source }, LanguageNames.CSharp, GetCSharpDiagnosticAnalyzer(), expected);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Called to test a VB DiagnosticAnalyzer when applied on the single inputted string as a source
|
|
/// Note: input a DiagnosticResult for each Diagnostic expected
|
|
/// </summary>
|
|
/// <param name="source">A class in the form of a string to run the analyzer on</param>
|
|
/// <param name="expected">DiagnosticResults that should appear after the analyzer is run on the source</param>
|
|
protected void VerifyBasicDiagnostic(string source, params DiagnosticResult[] expected)
|
|
{
|
|
VerifyDiagnostics(new[] { source }, LanguageNames.VisualBasic, GetBasicDiagnosticAnalyzer(), expected);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Called to test a C# DiagnosticAnalyzer when applied on the inputted strings as a source
|
|
/// Note: input a DiagnosticResult for each Diagnostic expected
|
|
/// </summary>
|
|
/// <param name="sources">An array of strings to create source documents from to run the analyzers on</param>
|
|
/// <param name="expected">DiagnosticResults that should appear after the analyzer is run on the sources</param>
|
|
protected void VerifyCSharpDiagnostic(string[] sources, params DiagnosticResult[] expected)
|
|
{
|
|
VerifyDiagnostics(sources, LanguageNames.CSharp, GetCSharpDiagnosticAnalyzer(), expected);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Called to test a VB DiagnosticAnalyzer when applied on the inputted strings as a source
|
|
/// Note: input a DiagnosticResult for each Diagnostic expected
|
|
/// </summary>
|
|
/// <param name="sources">An array of strings to create source documents from to run the analyzers on</param>
|
|
/// <param name="expected">DiagnosticResults that should appear after the analyzer is run on the sources</param>
|
|
protected void VerifyBasicDiagnostic(string[] sources, params DiagnosticResult[] expected)
|
|
{
|
|
VerifyDiagnostics(sources, LanguageNames.VisualBasic, GetBasicDiagnosticAnalyzer(), expected);
|
|
}
|
|
|
|
/// <summary>
|
|
/// General method that gets a collection of actual diagnostics found in the source after the analyzer is run,
|
|
/// then verifies each of them.
|
|
/// </summary>
|
|
/// <param name="sources">An array of strings to create source documents from to run the analyzers on</param>
|
|
/// <param name="language">The language of the classes represented by the source strings</param>
|
|
/// <param name="analyzer">The analyzer to be run on the source code</param>
|
|
/// <param name="expected">DiagnosticResults that should appear after the analyzer is run on the sources</param>
|
|
private void VerifyDiagnostics(string[] sources, string language, DiagnosticAnalyzer analyzer, params DiagnosticResult[] expected)
|
|
{
|
|
var diagnostics = GetSortedDiagnostics(sources, language, analyzer);
|
|
VerifyDiagnosticResults(diagnostics, analyzer, expected);
|
|
}
|
|
|
|
#endregion
|
|
|
|
#region Actual comparisons and verifications
|
|
/// <summary>
|
|
/// Checks each of the actual Diagnostics found and compares them with the corresponding DiagnosticResult in the array of expected results.
|
|
/// Diagnostics are considered equal only if the DiagnosticResultLocation, Id, Severity, and Message of the DiagnosticResult match the actual diagnostic.
|
|
/// </summary>
|
|
/// <param name="actualResults">The Diagnostics found by the compiler after running the analyzer on the source code</param>
|
|
/// <param name="analyzer">The analyzer that was being run on the sources</param>
|
|
/// <param name="expectedResults">Diagnostic Results that should have appeared in the code</param>
|
|
private static void VerifyDiagnosticResults(IEnumerable<Diagnostic> actualResults, DiagnosticAnalyzer analyzer, params DiagnosticResult[] expectedResults)
|
|
{
|
|
int expectedCount = expectedResults.Length;
|
|
int actualCount = actualResults.Count();
|
|
|
|
if (expectedCount != actualCount)
|
|
{
|
|
string diagnosticsOutput = actualResults.Any() ? FormatDiagnostics(analyzer, actualResults.ToArray()) : " NONE.";
|
|
|
|
Assert.True(false,
|
|
string.Format("Mismatch between number of diagnostics returned, expected \"{0}\" actual \"{1}\"\r\n\r\nDiagnostics:\r\n{2}\r\n", expectedCount, actualCount, diagnosticsOutput));
|
|
}
|
|
|
|
for (int i = 0; i < expectedResults.Length; i++)
|
|
{
|
|
var actual = actualResults.ElementAt(i);
|
|
var expected = expectedResults[i];
|
|
|
|
if (expected.Line == -1 && expected.Column == -1)
|
|
{
|
|
if (actual.Location != Location.None)
|
|
{
|
|
Assert.True(false,
|
|
string.Format("Expected:\nA project diagnostic with No location\nActual:\n{0}",
|
|
FormatDiagnostics(analyzer, actual)));
|
|
}
|
|
}
|
|
else
|
|
{
|
|
VerifyDiagnosticLocation(analyzer, actual, actual.Location, expected.Locations.First());
|
|
var additionalLocations = actual.AdditionalLocations.ToArray();
|
|
|
|
if (additionalLocations.Length != expected.Locations.Length - 1)
|
|
{
|
|
Assert.True(false,
|
|
string.Format("Expected {0} additional locations but got {1} for Diagnostic:\r\n {2}\r\n",
|
|
expected.Locations.Length - 1, additionalLocations.Length,
|
|
FormatDiagnostics(analyzer, actual)));
|
|
}
|
|
|
|
for (int j = 0; j < additionalLocations.Length; ++j)
|
|
{
|
|
VerifyDiagnosticLocation(analyzer, actual, additionalLocations[j], expected.Locations[j + 1]);
|
|
}
|
|
}
|
|
|
|
if (actual.Id != expected.Id)
|
|
{
|
|
Assert.True(false,
|
|
string.Format("Expected diagnostic id to be \"{0}\" was \"{1}\"\r\n\r\nDiagnostic:\r\n {2}\r\n",
|
|
expected.Id, actual.Id, FormatDiagnostics(analyzer, actual)));
|
|
}
|
|
|
|
if (actual.Severity != expected.Severity)
|
|
{
|
|
Assert.True(false,
|
|
string.Format("Expected diagnostic severity to be \"{0}\" was \"{1}\"\r\n\r\nDiagnostic:\r\n {2}\r\n",
|
|
expected.Severity, actual.Severity, FormatDiagnostics(analyzer, actual)));
|
|
}
|
|
|
|
if (actual.GetMessage() != expected.Message)
|
|
{
|
|
Assert.True(false,
|
|
string.Format("Expected diagnostic message to be \"{0}\" was \"{1}\"\r\n\r\nDiagnostic:\r\n {2}\r\n",
|
|
expected.Message, actual.GetMessage(), FormatDiagnostics(analyzer, actual)));
|
|
}
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// Helper method to VerifyDiagnosticResult that checks the location of a diagnostic and compares it with the location in the expected DiagnosticResult.
|
|
/// </summary>
|
|
/// <param name="analyzer">The analyzer that was being run on the sources</param>
|
|
/// <param name="diagnostic">The diagnostic that was found in the code</param>
|
|
/// <param name="actual">The Location of the Diagnostic found in the code</param>
|
|
/// <param name="expected">The DiagnosticResultLocation that should have been found</param>
|
|
private static void VerifyDiagnosticLocation(DiagnosticAnalyzer analyzer, Diagnostic diagnostic, Location actual, DiagnosticResultLocation expected)
|
|
{
|
|
var actualSpan = actual.GetLineSpan();
|
|
|
|
Assert.True(actualSpan.Path == expected.Path || (actualSpan.Path != null && actualSpan.Path.Contains("Test0.") && expected.Path.Contains("Test.")),
|
|
string.Format("Expected diagnostic to be in file \"{0}\" was actually in file \"{1}\"\r\n\r\nDiagnostic:\r\n {2}\r\n",
|
|
expected.Path, actualSpan.Path, FormatDiagnostics(analyzer, diagnostic)));
|
|
|
|
var actualLinePosition = actualSpan.StartLinePosition;
|
|
|
|
// Only check line position if there is an actual line in the real diagnostic
|
|
if (actualLinePosition.Line > 0)
|
|
{
|
|
if (actualLinePosition.Line + 1 != expected.Line)
|
|
{
|
|
Assert.True(false,
|
|
string.Format("Expected diagnostic to be on line \"{0}\" was actually on line \"{1}\"\r\n\r\nDiagnostic:\r\n {2}\r\n",
|
|
expected.Line, actualLinePosition.Line + 1, FormatDiagnostics(analyzer, diagnostic)));
|
|
}
|
|
}
|
|
|
|
// Only check column position if there is an actual column position in the real diagnostic
|
|
if (actualLinePosition.Character > 0)
|
|
{
|
|
if (actualLinePosition.Character + 1 != expected.Column)
|
|
{
|
|
Assert.True(false,
|
|
string.Format("Expected diagnostic to start at column \"{0}\" was actually at column \"{1}\"\r\n\r\nDiagnostic:\r\n {2}\r\n",
|
|
expected.Column, actualLinePosition.Character + 1, FormatDiagnostics(analyzer, diagnostic)));
|
|
}
|
|
}
|
|
}
|
|
#endregion
|
|
|
|
#region Formatting Diagnostics
|
|
/// <summary>
|
|
/// Helper method to format a Diagnostic into an easily readable string
|
|
/// </summary>
|
|
/// <param name="analyzer">The analyzer that this verifier tests</param>
|
|
/// <param name="diagnostics">The Diagnostics to be formatted</param>
|
|
/// <returns>The Diagnostics formatted as a string</returns>
|
|
private static string FormatDiagnostics(DiagnosticAnalyzer analyzer, params Diagnostic[] diagnostics)
|
|
{
|
|
var builder = new StringBuilder();
|
|
for (int i = 0; i < diagnostics.Length; ++i)
|
|
{
|
|
builder.AppendLine("// " + diagnostics[i].ToString());
|
|
|
|
var analyzerType = analyzer.GetType();
|
|
var rules = analyzer.SupportedDiagnostics;
|
|
|
|
foreach (var rule in rules)
|
|
{
|
|
if (rule != null && rule.Id == diagnostics[i].Id)
|
|
{
|
|
var location = diagnostics[i].Location;
|
|
if (location == Location.None)
|
|
{
|
|
builder.AppendFormat("GetGlobalResult({0}.{1})", analyzerType.Name, rule.Id);
|
|
}
|
|
else
|
|
{
|
|
Assert.True(location.IsInSource,
|
|
$"Test base does not currently handle diagnostics in metadata locations. Diagnostic in metadata: {diagnostics[i]}\r\n");
|
|
|
|
string resultMethodName = diagnostics[i].Location.SourceTree.FilePath.EndsWith(".cs") ? "GetCSharpResultAt" : "GetBasicResultAt";
|
|
var linePosition = diagnostics[i].Location.GetLineSpan().StartLinePosition;
|
|
|
|
builder.AppendFormat("{0}({1}, {2}, {3}.{4})",
|
|
resultMethodName,
|
|
linePosition.Line + 1,
|
|
linePosition.Character + 1,
|
|
analyzerType.Name,
|
|
rule.Id);
|
|
}
|
|
|
|
if (i != diagnostics.Length - 1)
|
|
{
|
|
builder.Append(',');
|
|
}
|
|
|
|
builder.AppendLine();
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
return builder.ToString();
|
|
}
|
|
#endregion
|
|
}
|
|
}
|