github/DotNetSolutionTools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix warnings

Browse Source
This commit is contained in:
Matthew Parker [SSW]
2024-05-21 19:07:26 +10:00
parent 94e01383c5
commit 1c253c5fbc
3 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
DotNetSolutionTools.App/ViewModels/MainWindowViewModel.cs
View File

@@ -116,8 +116,7 @@ public partial class MainWindowViewModel : ObservableObject
await Task.Run( await Task.Run(
() => () =>
{ {
var solutionFile = SlnHelper.ParseSolutionFileFromPath(SolutionFilePath); var csprojList = CsprojHelper.RetrieveAllCSharpProjectFullPathsFromSolution(SolutionFilePath);
var csprojList = CsprojHelper.RetrieveAllCSharpProjectFullPathsFromSolution(solutionFile);
foreach (var csproj in csprojList) foreach (var csproj in csprojList)
{ {
FormatCsproj.FormatCsprojFile(csproj); FormatCsproj.FormatCsprojFile(csproj);

6
DotNetSolutionTools.Core/Common/CsprojHelper.cs
View File

@@ -15,9 +15,11 @@ public static class CsprojHelper
return csprojList; return csprojList;
} }
public static string[] RetrieveAllCSharpProjectFullPathsFromSolution(SolutionFile solution) public static string[] RetrieveAllCSharpProjectFullPathsFromSolution(string solutionFilePath)
{ {
var result = SlnHelper.GetCSharpProjectObjectsFromSolutionFile(solution); var solutionFile = SlnHelper.ParseSolutionFileFromPath(solutionFilePath);
ArgumentNullException.ThrowIfNull(solutionFile);
var result = SlnHelper.GetCSharpProjectObjectsFromSolutionFile(solutionFile);
var csprojList = result.Select(x => x.FullPath).ToArray(); var csprojList = result.Select(x => x.FullPath).ToArray();
return csprojList; return csprojList;
} }

6
DotNetSolutionTools.Core/Infrastructure/NugetLookup.cs
View File

@@ -1,4 +1,5 @@
using NuGet.Common; using System.Diagnostics.CodeAnalysis;
using NuGet.Common;
using NuGet.Protocol; using NuGet.Protocol;
using NuGet.Protocol.Core.Types; using NuGet.Protocol.Core.Types;
using NuGet.Versioning; using NuGet.Versioning;
@@ -54,7 +55,8 @@ public static class NugetLookup
return latestStableVersion; return latestStableVersion;
} }
public static void Throw(string packageId) [DoesNotReturn]
private static void Throw(string packageId)
{ {
throw new ArgumentNullException( throw new ArgumentNullException(
"latestVersion", "latestVersion",