github/DotNetSolutionTools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

100x perf

Browse Source
This commit is contained in:
Matthew Parker [SSW]
2024-05-21 18:40:58 +10:00
parent 0c036ab772
commit 8bb3c0367f
1 changed files with 17 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
DotNetSolutionTools.Core/PackageVersionConsistency.cs
View File

@@ -1,4 +1,5 @@
using DotNetSolutionTools.Core.Common; using System.Collections.Concurrent;
using DotNetSolutionTools.Core.Common;
using Microsoft.Build.Construction; using Microsoft.Build.Construction;
using Microsoft.Build.Definition; using Microsoft.Build.Definition;
using Microsoft.Build.Evaluation; using Microsoft.Build.Evaluation;
@@ -13,7 +14,19 @@ public class PackageVersionConsistency
var solutionFile = SolutionFile.Parse(solutionFilePath); var solutionFile = SolutionFile.Parse(solutionFilePath);
var csprojList = SlnHelper.GetCSharpProjectObjectsFromSolutionFile(solutionFile); var csprojList = SlnHelper.GetCSharpProjectObjectsFromSolutionFile(solutionFile);
var packageList = new List<(string, NuGetVersion)>(); var packageList = new List<(string, NuGetVersion)>();
//var packageListConcurrent = new ConcurrentBag<(string, NuGetVersion)>();
var outOfSyncPackages = new List<(string packageName, NuGetVersion version)>(); var outOfSyncPackages = new List<(string packageName, NuGetVersion version)>();
// Parallel.ForEach(
// csprojList,
// project =>
// {
// var projectPackages = GetPackageVersions(project);
// lock (packageList)
// {
// packageList.AddRange(projectPackages);
// }
// }
// );
foreach (var project in csprojList) foreach (var project in csprojList)
{ {
var projectPackages = GetPackageVersions(project); var projectPackages = GetPackageVersions(project);
@@ -38,24 +51,14 @@ public class PackageVersionConsistency
private static List<(string, NuGetVersion)> GetPackageVersions(ProjectRootElement project) private static List<(string, NuGetVersion)> GetPackageVersions(ProjectRootElement project)
{ {
Project? evalProject = null;
try try
{ {
evalProject = Project.FromProjectRootElement( var packages = project
project, .Items.Where(x => x.ItemType == "PackageReference" && x.Metadata.Any(s => s.Name == "Version"))
new ProjectOptions { LoadSettings = ProjectLoadSettings.IgnoreMissingImports }
);
var packages = evalProject
.Items.Where(x => x.ItemType == "PackageReference" && x.HasMetadata("Version"))
.ToList(); .ToList();
var packageNameAndVersion = packages var packageNameAndVersion = packages
.Select(x => .Select(x => (x.Include, NuGetVersion.Parse(x.Metadata.First(s => s.Name == "Version").Value)))
(
x.EvaluatedInclude,
NuGetVersion.Parse(x.Metadata.First(s => s.Name == "Version").UnevaluatedValue)
)
)
.ToList(); .ToList();
return packageNameAndVersion; return packageNameAndVersion;
} }
@@ -64,13 +67,5 @@ public class PackageVersionConsistency
Console.WriteLine(e); Console.WriteLine(e);
throw; throw;
} }
finally
{
if (evalProject is not null)
{
ProjectCollection.GlobalProjectCollection.UnloadProject(evalProject);
ProjectCollection.GlobalProjectCollection.TryUnloadProject(project);
}
}
} }
} }