github/SharpIDE
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

improve navigation history via editor tab selection/closure

Browse Source
This commit is contained in:
Matt Parker
2025-10-30 00:36:27 +10:00
parent 4cff69abad
commit 38cdfdd147
1 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/SharpIDE.Godot/Features/CodeEditor/CodeEditorPanel.cs
View File

@@ -57,13 +57,23 @@ public partial class CodeEditorPanel : MarginContainer
private void OnTabClicked(long tab) private void OnTabClicked(long tab)
{ {
var sharpIdeFile = _tabContainer.GetChild<SharpIdeCodeEdit>((int)tab).SharpIdeFile; var sharpIdeCodeEdit = _tabContainer.GetChild<SharpIdeCodeEdit>((int)tab);
GodotGlobalEvents.Instance.FileExternallySelected.InvokeParallelFireAndForget(sharpIdeFile, null); var sharpIdeFile = sharpIdeCodeEdit.SharpIdeFile;
var caretLinePosition = new SharpIdeFileLinePosition(sharpIdeCodeEdit.GetCaretLine(), sharpIdeCodeEdit.GetCaretColumn());
GodotGlobalEvents.Instance.FileExternallySelected.InvokeParallelFireAndForget(sharpIdeFile, caretLinePosition);
} }
private void OnTabClosePressed(long tabIndex) private void OnTabClosePressed(long tabIndex)
{ {
var tab = _tabContainer.GetChild<Control>((int)tabIndex); var tab = _tabContainer.GetChild<Control>((int)tabIndex);
var previousSibling = _tabContainer.GetChildOrNull<SharpIdeCodeEdit>((int)tabIndex - 1);
if (previousSibling is not null)
{
var sharpIdeFile = previousSibling.SharpIdeFile;
var caretLinePosition = new SharpIdeFileLinePosition(previousSibling.GetCaretLine(), previousSibling.GetCaretColumn());
// This isn't actually necessary - closing a tab automatically selects the previous tab, however we need to do it to select the file in sln explorer, record navigation event etc
GodotGlobalEvents.Instance.FileExternallySelected.InvokeParallelFireAndForget(sharpIdeFile, caretLinePosition);
}
_tabContainer.RemoveChild(tab); _tabContainer.RemoveChild(tab);
tab.QueueFree(); tab.QueueFree();
} }