From 5e4cefe71bd0476cac1fc44c277d8e107cb2e234 Mon Sep 17 00:00:00 2001 From: Matt Parker <61717342+MattParkerDev@users.noreply.github.com> Date: Fri, 1 Aug 2025 21:17:06 +1000 Subject: [PATCH] refactor --- .../Features/Build/BuildService.cs | 6 ------ .../Features/Logging/InternalTerminalLoggerFactory.cs | 11 ++++++++++- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/src/SharpIDE.Application/Features/Build/BuildService.cs b/src/SharpIDE.Application/Features/Build/BuildService.cs index fd227a7..2f05901 100644 --- a/src/SharpIDE.Application/Features/Build/BuildService.cs +++ b/src/SharpIDE.Application/Features/Build/BuildService.cs @@ -1,9 +1,5 @@ using System.Diagnostics; -using System.Text; -using System.Threading.Channels; using Microsoft.Build.Execution; -using Microsoft.Build.Framework; -using Microsoft.Build.Logging; using SharpIDE.Application.Features.Logging; namespace SharpIDE.Application.Features.Build; @@ -24,8 +20,6 @@ public class BuildService var normalOut = Console.Out; Console.SetOut(BuildTextWriter); var terminalLogger = InternalTerminalLoggerFactory.CreateLogger(); - terminalLogger.Parameters = "FORCECONSOLECOLOR"; - terminalLogger.Verbosity = LoggerVerbosity.Minimal; var buildParameters = new BuildParameters { Loggers = diff --git a/src/SharpIDE.Application/Features/Logging/InternalTerminalLoggerFactory.cs b/src/SharpIDE.Application/Features/Logging/InternalTerminalLoggerFactory.cs index f32756f..dc02293 100644 --- a/src/SharpIDE.Application/Features/Logging/InternalTerminalLoggerFactory.cs +++ b/src/SharpIDE.Application/Features/Logging/InternalTerminalLoggerFactory.cs @@ -6,6 +6,12 @@ namespace SharpIDE.Application.Features.Logging; public class InternalTerminalLoggerFactory { public static ILogger CreateLogger() + { + var logger = CreateLogger("FORCECONSOLECOLOR", LoggerVerbosity.Minimal); + return logger; + } + + public static ILogger CreateLogger(string parameters, LoggerVerbosity loggerVerbosity) { var type = Type.GetType("Microsoft.Build.Logging.TerminalLogger, Microsoft.Build"); @@ -26,6 +32,9 @@ public class InternalTerminalLoggerFactory obj: null, parameters: [args, supportsAnsi, outputIsScreen, originalConsoleMode]); - return (ILogger)logger!; // This will be an ILogger (or INodeLogger) instance + var castLogger = (ILogger)logger!; + castLogger.Parameters = parameters; + castLogger.Verbosity = loggerVerbosity; + return castLogger; } }