github/SharpIDE
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

handle ResumeRuntime order conditionally

Browse Source
This commit is contained in:
Matt Parker
2025-12-31 19:28:44 +10:00
parent a198378999
commit 9ac7424304
1 changed files with 16 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/SharpIDE.Application/Features/Debugging/DebuggingService.cs
View File

@@ -25,6 +25,7 @@ public class DebuggingService
{ {
throw new ArgumentNullException(nameof(debuggerExecutablePath), "Debugger executable path cannot be null or empty."); throw new ArgumentNullException(nameof(debuggerExecutablePath), "Debugger executable path cannot be null or empty.");
} }
var isNetCoreDbg = Path.GetFileNameWithoutExtension(debuggerExecutablePath).Equals("netcoredbg", StringComparison.OrdinalIgnoreCase);
var process = new Process var process = new Process
{ {
@@ -159,11 +160,22 @@ public class DebuggingService
var breakpointsResponse = debugProtocolHost.SendRequestSync(setBreakpointsRequest); var breakpointsResponse = debugProtocolHost.SendRequestSync(setBreakpointsRequest);
} }
// netcoredbg has (a bug?) differing behaviour here compared to sharpdbg, where ConfigurationDone will never return if the runtime is paused at startup
// so if using netcoredbg, we must ResumeRuntime first
// Note that this means breakpoints on e.g. the first line of Main may be missed. It would be ideal for netcoredbg to fix this behaviour.
if (isNetCoreDbg)
{
new DiagnosticsClient(debuggeeProcessId).ResumeRuntime(); new DiagnosticsClient(debuggeeProcessId).ResumeRuntime();
var configurationDoneRequest = new ConfigurationDoneRequest(); var configurationDoneRequest = new ConfigurationDoneRequest();
debugProtocolHost.SendRequestSync(configurationDoneRequest); debugProtocolHost.SendRequestSync(configurationDoneRequest);
} }
// Typically you would do attachRequest, setBreakpointsRequest, configurationDoneRequest, then ResumeRuntime. But netcoredbg blows up on configurationDoneRequest if ResumeRuntime hasn't been called yet. else
{
var configurationDoneRequest = new ConfigurationDoneRequest();
debugProtocolHost.SendRequestSync(configurationDoneRequest);
new DiagnosticsClient(debuggeeProcessId).ResumeRuntime();
}
}
public async Task SetBreakpointsForFile(SharpIdeFile file, List<Breakpoint> breakpoints, CancellationToken cancellationToken = default) public async Task SetBreakpointsForFile(SharpIdeFile file, List<Breakpoint> breakpoints, CancellationToken cancellationToken = default)
{ {