github/SharpIDE
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

wrap StoppedEvent handler in try catch

Browse Source
This commit is contained in:
Matt Parker
2025-12-30 16:28:55 +10:00
parent 0aaec7e103
commit a198378999
1 changed files with 32 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
src/SharpIDE.Application/Features/Debugging/DebuggingService.cs
View File

@@ -80,33 +80,41 @@ public class DebuggingService
}); });
debugProtocolHost.RegisterEventType<StoppedEvent>(async void (@event) => debugProtocolHost.RegisterEventType<StoppedEvent>(async void (@event) =>
{ {
await Task.CompletedTask.ConfigureAwait(ConfigureAwaitOptions.ForceYielding); // The VS Code Debug Protocol throws if you try to send a request from the dispatcher thread try
var additionalProperties = @event.AdditionalProperties;
// source, line, column
if (additionalProperties.Count is not 0)
{ {
var filePath = additionalProperties?["source"]?["path"]!.Value<string>()!; await Task.CompletedTask.ConfigureAwait(ConfigureAwaitOptions.ForceYielding); // The VS Code Debug Protocol throws if you try to send a request from the dispatcher thread
var line = (additionalProperties?["line"]?.Value<int>()!).Value; var additionalProperties = @event.AdditionalProperties;
var executionStopInfo = new ExecutionStopInfo { FilePath = filePath, Line = line, ThreadId = @event.ThreadId!.Value, Project = project }; // source, line, column
GlobalEvents.Instance.DebuggerExecutionStopped.InvokeParallelFireAndForget(executionStopInfo); if (additionalProperties.Count is not 0)
} {
else var filePath = additionalProperties?["source"]?["path"]!.Value<string>()!;
{ var line = (additionalProperties?["line"]?.Value<int>()!).Value;
// we need to get the top stack frame to find out where we are var executionStopInfo = new ExecutionStopInfo { FilePath = filePath, Line = line, ThreadId = @event.ThreadId!.Value, Project = project };
var stackTraceRequest = new StackTraceRequest { ThreadId = @event.ThreadId!.Value, StartFrame = 0, Levels = 1 }; GlobalEvents.Instance.DebuggerExecutionStopped.InvokeParallelFireAndForget(executionStopInfo);
var stackTraceResponse = debugProtocolHost.SendRequestSync(stackTraceRequest); }
var topFrame = stackTraceResponse.StackFrames.Single(); else
var filePath = topFrame.Source.Path; {
var line = topFrame.Line; // we need to get the top stack frame to find out where we are
var executionStopInfo = new ExecutionStopInfo { FilePath = filePath, Line = line, ThreadId = @event.ThreadId!.Value, Project = project }; var stackTraceRequest = new StackTraceRequest { ThreadId = @event.ThreadId!.Value, StartFrame = 0, Levels = 1 };
GlobalEvents.Instance.DebuggerExecutionStopped.InvokeParallelFireAndForget(executionStopInfo); var stackTraceResponse = debugProtocolHost.SendRequestSync(stackTraceRequest);
} var topFrame = stackTraceResponse.StackFrames.Single();
var filePath = topFrame.Source.Path;
var line = topFrame.Line;
var executionStopInfo = new ExecutionStopInfo { FilePath = filePath, Line = line, ThreadId = @event.ThreadId!.Value, Project = project };
GlobalEvents.Instance.DebuggerExecutionStopped.InvokeParallelFireAndForget(executionStopInfo);
}
if (@event.Reason is StoppedEvent.ReasonValue.Exception) if (@event.Reason is StoppedEvent.ReasonValue.Exception)
{
Console.WriteLine("Stopped due to exception, continuing");
var continueRequest = new ContinueRequest { ThreadId = @event.ThreadId!.Value };
_debugProtocolHost.SendRequestSync(continueRequest);
}
}
catch (Exception e)
{ {
Console.WriteLine("Stopped due to exception, continuing"); // TODO: use logger once this class is DI'd
var continueRequest = new ContinueRequest { ThreadId = @event.ThreadId!.Value }; Console.WriteLine($"Error handling StoppedEvent: {e}");
_debugProtocolHost.SendRequestSync(continueRequest);
} }
}); });
debugProtocolHost.VerifySynchronousOperationAllowed(); debugProtocolHost.VerifySynchronousOperationAllowed();