github/SharpIDE
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dispose of isDirty subscription when tab is freed

Browse Source
This commit is contained in:
Matt Parker
2025-10-10 23:22:11 +10:00
parent c415a095d1
commit fff3f1c544
1 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/SharpIDE.Godot/Features/CodeEditor/CodeEditorPanel.cs
View File

@@ -74,7 +74,7 @@ public partial class CodeEditorPanel : MarginContainer
_tabContainer.SetTabTitle(newTabIndex, file.Name); _tabContainer.SetTabTitle(newTabIndex, file.Name);
_tabContainer.SetTabTooltip(newTabIndex, file.Path); _tabContainer.SetTabTooltip(newTabIndex, file.Path);
_tabContainer.CurrentTab = newTabIndex; _tabContainer.CurrentTab = newTabIndex;
});
file.IsDirty.Skip(1).SubscribeOnThreadPool().SubscribeAwait(async (isDirty, ct) => file.IsDirty.Skip(1).SubscribeOnThreadPool().SubscribeAwait(async (isDirty, ct) =>
{ {
//GD.Print($"File dirty state changed: {file.Path} is now {(isDirty ? "dirty" : "clean")}"); //GD.Print($"File dirty state changed: {file.Path} is now {(isDirty ? "dirty" : "clean")}");
@@ -84,7 +84,9 @@ public partial class CodeEditorPanel : MarginContainer
var title = file.Name + (isDirty ? " (*)" : ""); var title = file.Name + (isDirty ? " (*)" : "");
_tabContainer.SetTabTitle(tabIndex, title); _tabContainer.SetTabTitle(tabIndex, title);
}); });
}).AddTo(newTab); // needs to be on ui thread
}); });
await newTab.SetSharpIdeFile(file); await newTab.SetSharpIdeFile(file);
if (fileLinePosition is not null) await this.InvokeAsync(() => newTab.SetFileLinePosition(fileLinePosition.Value)); if (fileLinePosition is not null) await this.InvokeAsync(() => newTab.SetFileLinePosition(fileLinePosition.Value));
} }