github/TREK
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(mcp): route search_place through mapsService to support Google Maps

Browse Source 
The search_place MCP tool was hardcoding a direct Nominatim call, ignoring
any configured Google Maps API key and never returning google_place_id despite
the tool description advertising it. Replace the inline fetch with the existing
searchPlaces() service which already switches between Google and Nominatim.

Update unit tests to mock mapsService instead of global fetch, and add a
dedicated test case for the Google path returning google_place_id.

Closes #424
This commit is contained in:
jubnl
2026-04-05 15:36:14 +02:00
parent 978d26f36c
commit 82f08360d7
2 changed files with 39 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
server/src/mcp/tools.ts
View File

@@ -22,6 +22,7 @@ import { createNote as createCollabNote, updateNote as updateCollabNote, deleteN
import {
markCountryVisited, unmarkCountryVisited, createBucketItem, deleteBucketItem,
} from '../services/atlasService';
import { searchPlaces } from '../services/mapsService';
const MAX_MCP_TRIP_DAYS = 90;
@@ -235,25 +236,12 @@ export function registerTools(server: McpServer, userId: number): void {
},
},
async ({ query }) => {
// Use Nominatim (no API key needed, always available)
const params = new URLSearchParams({
q: query, format: 'json', addressdetails: '1', limit: '5', 'accept-language': 'en',
});
const response = await fetch(`https://nominatim.openstreetmap.org/search?${params}`, {
headers: { 'User-Agent': 'TREK Travel Planner' },
});
if (!response.ok) {
return { content: [{ type: 'text' as const, text: 'Search failed — Nominatim API error.' }], isError: true };
try {
const result = await searchPlaces(userId, query);
return ok(result);
} catch {
return { content: [{ type: 'text' as const, text: 'Place search failed.' }], isError: true };
}
const data = await response.json() as { osm_type: string; osm_id: number; name: string; display_name: string; lat: string; lon: string }[];
const places = data.map(item => ({
osm_id: `${item.osm_type}:${item.osm_id}`,
name: item.name || item.display_name?.split(',')[0] || '',
address: item.display_name || '',
lat: parseFloat(item.lat) || null,
lng: parseFloat(item.lon) || null,
}));
return ok({ places });
}
);