Trip members viewing another member's shared photo were getting a 404 because the proxy endpoints always used the requesting user's Immich credentials instead of the photo owner's. The ?userId= query param the client already sent was silently ignored. - Add canAccessUserPhoto() to verify the asset is shared and the requesting user is a trip member before allowing cross-user proxying - Pass optional ownerUserId through proxyThumbnail, proxyOriginal, and getAssetInfo so credentials are fetched for the correct user - Enforce shared=1 check so unshared photos remain inaccessible
235 lines
11 KiB
TypeScript
235 lines
11 KiB
TypeScript
import express, { Request, Response, NextFunction } from 'express';
|
|
import { db, canAccessTrip } from '../db/database';
|
|
import { authenticate } from '../middleware/auth';
|
|
import { broadcast } from '../websocket';
|
|
import { AuthRequest } from '../types';
|
|
import { consumeEphemeralToken } from '../services/ephemeralTokens';
|
|
import { getClientIp } from '../services/auditLog';
|
|
import {
|
|
getConnectionSettings,
|
|
saveImmichSettings,
|
|
testConnection,
|
|
getConnectionStatus,
|
|
browseTimeline,
|
|
searchPhotos,
|
|
listTripPhotos,
|
|
addTripPhotos,
|
|
removeTripPhoto,
|
|
togglePhotoSharing,
|
|
getAssetInfo,
|
|
proxyThumbnail,
|
|
proxyOriginal,
|
|
isValidAssetId,
|
|
canAccessUserPhoto,
|
|
listAlbums,
|
|
listAlbumLinks,
|
|
createAlbumLink,
|
|
deleteAlbumLink,
|
|
syncAlbumAssets,
|
|
} from '../services/immichService';
|
|
|
|
const router = express.Router();
|
|
|
|
// ── Dual auth middleware (JWT or ephemeral token for <img> src) ─────────────
|
|
|
|
function authFromQuery(req: Request, res: Response, next: NextFunction) {
|
|
const queryToken = req.query.token as string | undefined;
|
|
if (queryToken) {
|
|
const userId = consumeEphemeralToken(queryToken, 'immich');
|
|
if (!userId) return res.status(401).send('Invalid or expired token');
|
|
const user = db.prepare('SELECT id, username, email, role, mfa_enabled FROM users WHERE id = ?').get(userId) as any;
|
|
if (!user) return res.status(401).send('User not found');
|
|
(req as AuthRequest).user = user;
|
|
return next();
|
|
}
|
|
return (authenticate as any)(req, res, next);
|
|
}
|
|
|
|
// ── Immich Connection Settings ─────────────────────────────────────────────
|
|
|
|
router.get('/settings', authenticate, (req: Request, res: Response) => {
|
|
const authReq = req as AuthRequest;
|
|
res.json(getConnectionSettings(authReq.user.id));
|
|
});
|
|
|
|
router.put('/settings', authenticate, async (req: Request, res: Response) => {
|
|
const authReq = req as AuthRequest;
|
|
const { immich_url, immich_api_key } = req.body;
|
|
const result = await saveImmichSettings(authReq.user.id, immich_url, immich_api_key, getClientIp(req));
|
|
if (!result.success) return res.status(400).json({ error: result.error });
|
|
if (result.warning) return res.json({ success: true, warning: result.warning });
|
|
res.json({ success: true });
|
|
});
|
|
|
|
router.get('/status', authenticate, async (req: Request, res: Response) => {
|
|
const authReq = req as AuthRequest;
|
|
res.json(await getConnectionStatus(authReq.user.id));
|
|
});
|
|
|
|
router.post('/test', authenticate, async (req: Request, res: Response) => {
|
|
const { immich_url, immich_api_key } = req.body;
|
|
if (!immich_url || !immich_api_key) return res.json({ connected: false, error: 'URL and API key required' });
|
|
res.json(await testConnection(immich_url, immich_api_key));
|
|
});
|
|
|
|
// ── Browse Immich Library (for photo picker) ───────────────────────────────
|
|
|
|
router.get('/browse', authenticate, async (req: Request, res: Response) => {
|
|
const authReq = req as AuthRequest;
|
|
const result = await browseTimeline(authReq.user.id);
|
|
if (result.error) return res.status(result.status!).json({ error: result.error });
|
|
res.json({ buckets: result.buckets });
|
|
});
|
|
|
|
router.post('/search', authenticate, async (req: Request, res: Response) => {
|
|
const authReq = req as AuthRequest;
|
|
const { from, to } = req.body;
|
|
const result = await searchPhotos(authReq.user.id, from, to);
|
|
if (result.error) return res.status(result.status!).json({ error: result.error });
|
|
res.json({ assets: result.assets });
|
|
});
|
|
|
|
// ── Trip Photos (selected by user) ────────────────────────────────────────
|
|
|
|
router.get('/trips/:tripId/photos', authenticate, (req: Request, res: Response) => {
|
|
const authReq = req as AuthRequest;
|
|
const { tripId } = req.params;
|
|
if (!canAccessTrip(tripId, authReq.user.id)) return res.status(404).json({ error: 'Trip not found' });
|
|
res.json({ photos: listTripPhotos(tripId, authReq.user.id) });
|
|
});
|
|
|
|
router.post('/trips/:tripId/photos', authenticate, (req: Request, res: Response) => {
|
|
const authReq = req as AuthRequest;
|
|
const { tripId } = req.params;
|
|
if (!canAccessTrip(tripId, authReq.user.id)) return res.status(404).json({ error: 'Trip not found' });
|
|
const { asset_ids, shared = true } = req.body;
|
|
|
|
if (!Array.isArray(asset_ids) || asset_ids.length === 0) {
|
|
return res.status(400).json({ error: 'asset_ids required' });
|
|
}
|
|
|
|
const added = addTripPhotos(tripId, authReq.user.id, asset_ids, shared);
|
|
res.json({ success: true, added });
|
|
broadcast(tripId, 'memories:updated', { userId: authReq.user.id }, req.headers['x-socket-id'] as string);
|
|
|
|
// Notify trip members about shared photos
|
|
if (shared && added > 0) {
|
|
import('../services/notifications').then(({ notifyTripMembers }) => {
|
|
const tripInfo = db.prepare('SELECT title FROM trips WHERE id = ?').get(tripId) as { title: string } | undefined;
|
|
notifyTripMembers(Number(tripId), authReq.user.id, 'photos_shared', { trip: tripInfo?.title || 'Untitled', actor: authReq.user.email, count: String(added) }).catch(() => {});
|
|
});
|
|
}
|
|
});
|
|
|
|
router.delete('/trips/:tripId/photos/:assetId', authenticate, (req: Request, res: Response) => {
|
|
const authReq = req as AuthRequest;
|
|
if (!canAccessTrip(req.params.tripId, authReq.user.id)) return res.status(404).json({ error: 'Trip not found' });
|
|
removeTripPhoto(req.params.tripId, authReq.user.id, req.params.assetId);
|
|
res.json({ success: true });
|
|
broadcast(req.params.tripId, 'memories:updated', { userId: authReq.user.id }, req.headers['x-socket-id'] as string);
|
|
});
|
|
|
|
router.put('/trips/:tripId/photos/:assetId/sharing', authenticate, (req: Request, res: Response) => {
|
|
const authReq = req as AuthRequest;
|
|
if (!canAccessTrip(req.params.tripId, authReq.user.id)) return res.status(404).json({ error: 'Trip not found' });
|
|
const { shared } = req.body;
|
|
togglePhotoSharing(req.params.tripId, authReq.user.id, req.params.assetId, shared);
|
|
res.json({ success: true });
|
|
broadcast(req.params.tripId, 'memories:updated', { userId: authReq.user.id }, req.headers['x-socket-id'] as string);
|
|
});
|
|
|
|
// ── Asset Details ──────────────────────────────────────────────────────────
|
|
|
|
router.get('/assets/:assetId/info', authenticate, async (req: Request, res: Response) => {
|
|
const authReq = req as AuthRequest;
|
|
const { assetId } = req.params;
|
|
if (!isValidAssetId(assetId)) return res.status(400).json({ error: 'Invalid asset ID' });
|
|
const queryUserId = req.query.userId ? Number(req.query.userId) : undefined;
|
|
const ownerUserId = queryUserId && queryUserId !== authReq.user.id ? queryUserId : undefined;
|
|
if (ownerUserId && !canAccessUserPhoto(authReq.user.id, ownerUserId, assetId)) {
|
|
return res.status(403).json({ error: 'Forbidden' });
|
|
}
|
|
const result = await getAssetInfo(authReq.user.id, assetId, ownerUserId);
|
|
if (result.error) return res.status(result.status!).json({ error: result.error });
|
|
res.json(result.data);
|
|
});
|
|
|
|
// ── Proxy Immich Assets ────────────────────────────────────────────────────
|
|
|
|
router.get('/assets/:assetId/thumbnail', authFromQuery, async (req: Request, res: Response) => {
|
|
const authReq = req as AuthRequest;
|
|
const { assetId } = req.params;
|
|
if (!isValidAssetId(assetId)) return res.status(400).send('Invalid asset ID');
|
|
const queryUserId = req.query.userId ? Number(req.query.userId) : undefined;
|
|
const ownerUserId = queryUserId && queryUserId !== authReq.user.id ? queryUserId : undefined;
|
|
if (ownerUserId && !canAccessUserPhoto(authReq.user.id, ownerUserId, assetId)) {
|
|
return res.status(403).send('Forbidden');
|
|
}
|
|
const result = await proxyThumbnail(authReq.user.id, assetId, ownerUserId);
|
|
if (result.error) return res.status(result.status!).send(result.error);
|
|
res.set('Content-Type', result.contentType!);
|
|
res.set('Cache-Control', 'public, max-age=86400');
|
|
res.send(result.buffer);
|
|
});
|
|
|
|
router.get('/assets/:assetId/original', authFromQuery, async (req: Request, res: Response) => {
|
|
const authReq = req as AuthRequest;
|
|
const { assetId } = req.params;
|
|
if (!isValidAssetId(assetId)) return res.status(400).send('Invalid asset ID');
|
|
const queryUserId = req.query.userId ? Number(req.query.userId) : undefined;
|
|
const ownerUserId = queryUserId && queryUserId !== authReq.user.id ? queryUserId : undefined;
|
|
if (ownerUserId && !canAccessUserPhoto(authReq.user.id, ownerUserId, assetId)) {
|
|
return res.status(403).send('Forbidden');
|
|
}
|
|
const result = await proxyOriginal(authReq.user.id, assetId, ownerUserId);
|
|
if (result.error) return res.status(result.status!).send(result.error);
|
|
res.set('Content-Type', result.contentType!);
|
|
res.set('Cache-Control', 'public, max-age=86400');
|
|
res.send(result.buffer);
|
|
});
|
|
|
|
// ── Album Linking ──────────────────────────────────────────────────────────
|
|
|
|
router.get('/albums', authenticate, async (req: Request, res: Response) => {
|
|
const authReq = req as AuthRequest;
|
|
const result = await listAlbums(authReq.user.id);
|
|
if (result.error) return res.status(result.status!).json({ error: result.error });
|
|
res.json({ albums: result.albums });
|
|
});
|
|
|
|
router.get('/trips/:tripId/album-links', authenticate, (req: Request, res: Response) => {
|
|
const authReq = req as AuthRequest;
|
|
if (!canAccessTrip(req.params.tripId, authReq.user.id)) return res.status(404).json({ error: 'Trip not found' });
|
|
res.json({ links: listAlbumLinks(req.params.tripId) });
|
|
});
|
|
|
|
router.post('/trips/:tripId/album-links', authenticate, async (req: Request, res: Response) => {
|
|
const authReq = req as AuthRequest;
|
|
const { tripId } = req.params;
|
|
if (!canAccessTrip(tripId, authReq.user.id)) return res.status(404).json({ error: 'Trip not found' });
|
|
const { album_id, album_name } = req.body;
|
|
if (!album_id) return res.status(400).json({ error: 'album_id required' });
|
|
const result = createAlbumLink(tripId, authReq.user.id, album_id, album_name);
|
|
if (!result.success) return res.status(400).json({ error: result.error });
|
|
res.json({ success: true });
|
|
});
|
|
|
|
router.delete('/trips/:tripId/album-links/:linkId', authenticate, (req: Request, res: Response) => {
|
|
const authReq = req as AuthRequest;
|
|
deleteAlbumLink(req.params.linkId, req.params.tripId, authReq.user.id);
|
|
res.json({ success: true });
|
|
});
|
|
|
|
router.post('/trips/:tripId/album-links/:linkId/sync', authenticate, async (req: Request, res: Response) => {
|
|
const authReq = req as AuthRequest;
|
|
const { tripId, linkId } = req.params;
|
|
const result = await syncAlbumAssets(tripId, linkId, authReq.user.id);
|
|
if (result.error) return res.status(result.status!).json({ error: result.error });
|
|
res.json({ success: true, added: result.added, total: result.total });
|
|
if (result.added! > 0) {
|
|
broadcast(tripId, 'memories:updated', { userId: authReq.user.id }, req.headers['x-socket-id'] as string);
|
|
}
|
|
});
|
|
|
|
export default router;
|