Make releasedata.Product usable in 'with' expression (#294)
This way the writing of the JSON file is handled automatically if the update does not fail. It pave the way to further global improvements, such as a better error handling.
This commit is contained in:
@@ -8,16 +8,14 @@ from common import dates, http, releasedata
|
||||
RSS_URL = "https://docs.aws.amazon.com/neptune/latest/userguide/rssupdates.rss"
|
||||
VERSION_PATTERN = re.compile(r"^Engine version (?P<version>[0-9R.]+)$")
|
||||
|
||||
product = releasedata.Product("amazon-neptune")
|
||||
rss_response = http.fetch_url(RSS_URL)
|
||||
rss = xml.dom.minidom.parseString(rss_response.text)
|
||||
with releasedata.ProductData("amazon-neptune") as product_data:
|
||||
rss_response = http.fetch_url(RSS_URL)
|
||||
rss = xml.dom.minidom.parseString(rss_response.text)
|
||||
|
||||
for entry in rss.getElementsByTagName("item"):
|
||||
version_str = entry.getElementsByTagName("title")[0].firstChild.nodeValue
|
||||
date_str = entry.getElementsByTagName("pubDate")[0].firstChild.nodeValue
|
||||
for entry in rss.getElementsByTagName("item"):
|
||||
version_str = entry.getElementsByTagName("title")[0].firstChild.nodeValue
|
||||
date_str = entry.getElementsByTagName("pubDate")[0].firstChild.nodeValue
|
||||
|
||||
version_match = VERSION_PATTERN.match(version_str)
|
||||
if version_match:
|
||||
product.declare_version(version_match['version'], dates.parse_datetime(date_str))
|
||||
|
||||
product.write()
|
||||
version_match = VERSION_PATTERN.match(version_str)
|
||||
if version_match:
|
||||
product_data.declare_version(version_match['version'], dates.parse_datetime(date_str))
|
||||
|
||||
Reference in New Issue
Block a user