From 500a47902647152037c376a5a04db82135621142 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mike=20F=C3=A4hrmann?= Date: Fri, 18 Mar 2022 19:52:37 +0100 Subject: [PATCH] fix a third(!) bug in _check_cookies() (#2372) turns out tests are worthless if you get em wrong ... --- gallery_dl/extractor/common.py | 1 - test/test_cookies.py | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/gallery_dl/extractor/common.py b/gallery_dl/extractor/common.py index e3559f9b..48b9ca7b 100644 --- a/gallery_dl/extractor/common.py +++ b/gallery_dl/extractor/common.py @@ -373,7 +373,6 @@ class Extractor(): self.log.warning( "Cookie '%s' will expire in less than %s hour%s", cookie.name, hours + 1, "s" if hours else "") - continue names.discard(cookie.name) if not names: diff --git a/test/test_cookies.py b/test/test_cookies.py index 0657456e..188b54c7 100644 --- a/test/test_cookies.py +++ b/test/test_cookies.py @@ -180,14 +180,14 @@ class TestCookieUtils(unittest.TestCase): extr._cookiejar.set("a", "1", expires=now+100) with mock.patch.object(log, "warning") as mw: - self.assertFalse(extr._check_cookies(("a",))) + self.assertTrue(extr._check_cookies(("a",))) self.assertEqual(mw.call_count, 1) self.assertEqual(mw.call_args[0], ( "Cookie '%s' will expire in less than %s hour%s", "a", 1, "")) extr._cookiejar.set("a", "1", expires=now+100+7200) with mock.patch.object(log, "warning") as mw: - self.assertFalse(extr._check_cookies(("a",))) + self.assertTrue(extr._check_cookies(("a",))) self.assertEqual(mw.call_count, 1) self.assertEqual(mw.call_args[0], ( "Cookie '%s' will expire in less than %s hour%s", "a", 3, "s"))