From 52a5e39fc636a6152f8b01b55c27e8156a978e72 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mike=20F=C3=A4hrmann?= Date: Mon, 9 Feb 2026 16:14:56 +0100 Subject: [PATCH] [reddit:user] fix user lookup when using sub view (#8228 #9032) e.g. USER/submitted or USER/comments fixes regression introduced in c16892a1503594d74c161559d4a1abcc1f7270f3 --- gallery_dl/extractor/reddit.py | 6 +++--- test/results/reddit.py | 19 +++++++++++++++++++ 2 files changed, 22 insertions(+), 3 deletions(-) diff --git a/gallery_dl/extractor/reddit.py b/gallery_dl/extractor/reddit.py index 365ba469..23f7d43f 100644 --- a/gallery_dl/extractor/reddit.py +++ b/gallery_dl/extractor/reddit.py @@ -302,12 +302,12 @@ class RedditUserExtractor(RedditExtractor): subcategory = "user" directory_fmt = ("{category}", "Users", "{user[name]}") pattern = (r"(?:https?://)?(?:\w+\.)?reddit\.com/u(?:ser)?/" - r"([^/?#]+(?:/([a-z]+))?)/?(?:\?([^#]*))?$") + r"([^/?#]+)(/[a-z]+)?/?(?:\?([^#]*))?") example = "https://www.reddit.com/user/USER/" def __init__(self, match): if sub := match[2]: - self.subcategory += "-" + sub + self.subcategory += "-" + sub[1:] RedditExtractor.__init__(self, match) def submissions(self): @@ -316,7 +316,7 @@ class RedditUserExtractor(RedditExtractor): self.kwdict["user"] = user = self.api.user_about(username) submissions = self.api.submissions_user( - user["name"], text.parse_query(qs)) + user["name"] + (sub or ""), text.parse_query(qs)) if self.config("only", True): submissions = self._only(submissions, user) return submissions diff --git a/test/results/reddit.py b/test/results/reddit.py index ca09e773..ca1dc1a0 100644 --- a/test/results/reddit.py +++ b/test/results/reddit.py @@ -91,6 +91,25 @@ __tests__ = ( "#class" : reddit.RedditUserExtractor, }, +{ + "#url" : "https://www.reddit.com/user/SeichiScout/submitted/?sort=hot", + "#category": ("", "reddit", "user-submitted"), + "#class" : reddit.RedditUserExtractor, + "#pattern" : r"https://i\.redd\.it/\w+\.jpg", + "#range" : "1-25", + "#count" : 25, + "#archive" : False, + + "author" : "SeichiScout", + "author_fullname" : "t2_l8qpy6td6", + "user" : { + "created_utc" : 1724480738.0, + "id" : "l8qpy6td6", + "name" : "SeichiScout", + "verified" : True, + }, +}, + { "#url" : "https://www.reddit.com/r/lavaporn/comments/8cqhub/", "#category": ("", "reddit", "submission"),