improve _check_cookies()

Only loop over all cookies once instead of calling
cookiejar._find() for each cookie name.
This commit is contained in:
Mike Fährmann
2019-12-13 15:51:20 +01:00
parent 76e60d10a6
commit a4dd8b3dab

View File

@@ -229,12 +229,14 @@ class Extractor():
"""Check if all 'cookienames' are in the session's cookiejar""" """Check if all 'cookienames' are in the session's cookiejar"""
if domain is None: if domain is None:
domain = self.cookiedomain domain = self.cookiedomain
try:
for name in cookienames: names = set(cookienames)
self._cookiejar._find(name, domain) for cookie in self._cookiejar:
except KeyError: if cookie.domain == domain:
return False names.discard(cookie.name)
return True if not names:
return True
return False
def _get_date_min_max(self, dmin=None, dmax=None): def _get_date_min_max(self, dmin=None, dmax=None):
"""Retrieve and parse 'date-min' and 'date-max' config values""" """Retrieve and parse 'date-min' and 'date-max' config values"""