From d9d8172364c38232b42c708c502393cb2668f1c0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mike=20F=C3=A4hrmann?= Date: Wed, 20 Aug 2025 08:43:09 +0200 Subject: [PATCH] [tumblr:search] fix 'ValueError: not enough values to unpack' (#8079) fixes regression introduced in 21160a8b08f46c2bedc02d3b444d2bbf074eb56a --- gallery_dl/extractor/tumblr.py | 2 +- test/results/tumblr.py | 13 +++++++++---- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/gallery_dl/extractor/tumblr.py b/gallery_dl/extractor/tumblr.py index 46507c47..6eea76c1 100644 --- a/gallery_dl/extractor/tumblr.py +++ b/gallery_dl/extractor/tumblr.py @@ -382,7 +382,7 @@ class TumblrSearchExtractor(TumblrExtractor): example = "https://www.tumblr.com/search/QUERY" def posts(self): - _, _, _, search, mode, post_type, query = self.groups + search, mode, post_type, query = self.groups params = text.parse_query(query) return self.api.search(text.unquote(search), params, mode, post_type) diff --git a/test/results/tumblr.py b/test/results/tumblr.py index 71da2de5..2d0ea25d 100644 --- a/test/results/tumblr.py +++ b/test/results/tumblr.py @@ -381,28 +381,33 @@ __tests__ = ( { "#url" : "https://www.tumblr.com/search/nathan fielder", - "#category": ("", "tumblr", "search"), "#class" : tumblr.TumblrSearchExtractor, }, { "#url" : "https://www.tumblr.com/search/nathan fielder/recent/quote?src=typed_query", - "#category": ("", "tumblr", "search"), "#class" : tumblr.TumblrSearchExtractor, }, { "#url" : "https://www.tumblr.com/search/nathan%20fielder?t=90", - "#category": ("", "tumblr", "search"), "#class" : tumblr.TumblrSearchExtractor, }, { "#url" : "https://tumblr.com/search/nathan%20fielder?t=90", - "#category": ("", "tumblr", "search"), "#class" : tumblr.TumblrSearchExtractor, }, +{ + "#url" : "https://www.tumblr.com/search/Sonic?src=typed_query", + "#class" : tumblr.TumblrSearchExtractor, + "#options" : {"original": False}, + "#pattern" : r"https://\w+\.media\.tumblr\.com/.{10,}.\w+", + "#range" : "1-10", + "count" : range(1, 10), +}, + { "#url" : "https://www.tumblr.com/mikf123/following", "#class" : tumblr.TumblrFollowingExtractor,