From 03da033cd2270de097af8d63f4391c6d4e860046 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20H=C3=A5=C3=A5vi?= Date: Mon, 5 May 2025 15:05:48 +0200 Subject: [PATCH] Only use stale dns cache entries when the query result was successful (cherry picked from commit f233a56eeaa2363db61d9ae08938aff171f071b8) --- service/resolver/resolve.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/service/resolver/resolve.go b/service/resolver/resolve.go index 4b5b5181..e84858f5 100644 --- a/service/resolver/resolve.go +++ b/service/resolver/resolve.go @@ -184,7 +184,7 @@ func Resolve(ctx context.Context, q *Query) (rrCache *RRCache, err error) { case !rrCache.Expired(): // Return non-expired cached entry immediately. return rrCache, nil - case useStaleCache(): + case rrCache.RCode == dns.RcodeSuccess && useStaleCache(): // Return expired cache if we should use stale cache entries, // but start an async query instead. log.Tracer(ctx).Tracef(