Implement review suggestions

Fix local. resolving in Firefox
2020-07-15 13:59:56 +02:00
parent e369a9484a
commit 047352f9b5
9 changed files with 57 additions and 52 deletions
--- a/network/connection.go
+++ b/network/connection.go
@@ -152,7 +152,7 @@ func NewConnectionFromFirstPacket(pkt packet.Packet) *Connection {

 		// check if destination IP is the captive portal's IP
 		portal := netenv.GetCaptivePortal()
-		if portal.IP != nil && pkt.Info().Dst.Equal(portal.IP) {
+		if pkt.Info().Dst.Equal(portal.IP) {
 			scope = portal.Domain
 			entity.Domain = portal.Domain
 		}