github/portmaster
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #1012 from safing/fix/kext-not-stopping

Browse Source 
Added shutdown request for kext
This commit is contained in:
Vladimir Stoilov
2022-11-30 22:05:04 +02:00
committed by GitHub
parent d6ef0a28b9 225da9cc76
commit 04fac7dfa7
3 changed files with 28 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
firewall/interception/windowskext/handler.go
View File

@@ -81,10 +81,6 @@ func Handler(packets chan packet.Packet) {
defer close(packets) defer close(packets)
for { for {
if kextHandle == winInvalidHandleValue {
return
}
packetInfo, err := RecvVerdictRequest() packetInfo, err := RecvVerdictRequest()
if err != nil { if err != nil {
// Check if we are done with processing. // Check if we are done with processing.

24
firewall/interception/windowskext/kext.go
View File

@@ -79,10 +79,16 @@ func Start() error {
// Stop intercepting. // Stop intercepting.
func Stop() error { func Stop() error {
// Prepare kernel for shutdown
err := shutdownRequest()
if err != nil {
log.Warningf("winkext: shutdown request failed: %s", err)
}
kextLock.Lock() kextLock.Lock()
defer kextLock.Unlock() defer kextLock.Unlock()
err := closeDriver(kextHandle) err = closeDriver(kextHandle)
if err != nil { if err != nil {
log.Warningf("winkext: failed to close the handle: %s", err) log.Warningf("winkext: failed to close the handle: %s", err)
} }
@@ -105,6 +111,18 @@ func Stop() error {
return nil return nil
} }
func shutdownRequest() error {
kextLock.RLock()
defer kextLock.RUnlock()
if kextHandle == winInvalidHandleValue {
return ErrKextNotReady
}
// Sent a shutdown request so the kernel extension can prepare.
_, err := deviceIOControl(kextHandle, IOCTL_SHUTDOWN_REQUEST, nil, nil)
return err
}
// RecvVerdictRequest waits for the next verdict request from the kext. If a timeout is reached, both *VerdictRequest and error will be nil. // RecvVerdictRequest waits for the next verdict request from the kext. If a timeout is reached, both *VerdictRequest and error will be nil.
func RecvVerdictRequest() (*VerdictRequest, error) { func RecvVerdictRequest() (*VerdictRequest, error) {
kextLock.RLock() kextLock.RLock()
@@ -241,7 +259,7 @@ func UpdateVerdict(conn *network.Connection) error {
// Make driver request // Make driver request
data := asByteArray(&info) data := asByteArray(&info)
err := deviceIoControlDirect(kextHandle, IOCTL_UPDATE_VERDICT, data) _, err := deviceIOControl(kextHandle, IOCTL_UPDATE_VERDICT, data, nil)
return err return err
} }
@@ -256,7 +274,7 @@ func GetVersion() (*VersionInfo, error) {
} }
data := make([]uint8, 4) data := make([]uint8, 4)
err := deviceIoControlDirect(kextHandle, IOCTL_VERSION, data) _, err := deviceIOControl(kextHandle, IOCTL_VERSION, data, nil)
if err != nil { if err != nil {
return nil, err return nil, err

32
firewall/interception/windowskext/syscall.go
View File

@@ -15,13 +15,13 @@ const (
) )
var ( var (
IOCTL_VERSION = ctlCode(SIOCTL_TYPE, 0x800, METHOD_BUFFERED, windows.FILE_READ_DATA|windows.FILE_WRITE_DATA) IOCTL_VERSION = ctlCode(SIOCTL_TYPE, 0x800, METHOD_BUFFERED, windows.FILE_READ_DATA|windows.FILE_WRITE_DATA)
IOCTL_RECV_VERDICT_REQ_POLL = ctlCode(SIOCTL_TYPE, 0x801, METHOD_BUFFERED, windows.FILE_READ_DATA|windows.FILE_WRITE_DATA) // Not used IOCTL_SHUTDOWN_REQUEST = ctlCode(SIOCTL_TYPE, 0x801, METHOD_BUFFERED, windows.FILE_READ_DATA|windows.FILE_WRITE_DATA)
IOCTL_RECV_VERDICT_REQ = ctlCode(SIOCTL_TYPE, 0x802, METHOD_BUFFERED, windows.FILE_READ_DATA|windows.FILE_WRITE_DATA) IOCTL_RECV_VERDICT_REQ = ctlCode(SIOCTL_TYPE, 0x802, METHOD_BUFFERED, windows.FILE_READ_DATA|windows.FILE_WRITE_DATA)
IOCTL_SET_VERDICT = ctlCode(SIOCTL_TYPE, 0x803, METHOD_BUFFERED, windows.FILE_READ_DATA|windows.FILE_WRITE_DATA) IOCTL_SET_VERDICT = ctlCode(SIOCTL_TYPE, 0x803, METHOD_BUFFERED, windows.FILE_READ_DATA|windows.FILE_WRITE_DATA)
IOCTL_GET_PAYLOAD = ctlCode(SIOCTL_TYPE, 0x804, METHOD_BUFFERED, windows.FILE_READ_DATA|windows.FILE_WRITE_DATA) IOCTL_GET_PAYLOAD = ctlCode(SIOCTL_TYPE, 0x804, METHOD_BUFFERED, windows.FILE_READ_DATA|windows.FILE_WRITE_DATA)
IOCTL_CLEAR_CACHE = ctlCode(SIOCTL_TYPE, 0x805, METHOD_BUFFERED, windows.FILE_READ_DATA|windows.FILE_WRITE_DATA) IOCTL_CLEAR_CACHE = ctlCode(SIOCTL_TYPE, 0x805, METHOD_BUFFERED, windows.FILE_READ_DATA|windows.FILE_WRITE_DATA)
IOCTL_UPDATE_VERDICT = ctlCode(SIOCTL_TYPE, 0x806, METHOD_BUFFERED, windows.FILE_READ_DATA|windows.FILE_WRITE_DATA) IOCTL_UPDATE_VERDICT = ctlCode(SIOCTL_TYPE, 0x806, METHOD_BUFFERED, windows.FILE_READ_DATA|windows.FILE_WRITE_DATA)
) )
func ctlCode(device_type, function, method, access uint32) uint32 { func ctlCode(device_type, function, method, access uint32) uint32 {
@@ -69,21 +69,3 @@ func deviceIOControl(handle windows.Handle, code uint32, inData []byte, outData
return bytesReturned, err return bytesReturned, err
} }
// Use for METHOD_NEITHER IOCTL, the data buffer is passed directly to the kernel
func deviceIoControlDirect(handle windows.Handle, code uint32, data []byte) error {
var dataPtr *byte = nil
var dataSize uint32 = 0
if data != nil {
dataPtr = &data[0]
dataSize = uint32(len(data))
}
err := windows.DeviceIoControl(handle,
code,
dataPtr, dataSize,
nil, 0,
nil, nil)
return err
}