From 1462bd07ff4227c39d401ec07e518af748a96041 Mon Sep 17 00:00:00 2001 From: Daniel Date: Fri, 25 Feb 2022 15:37:54 +0100 Subject: [PATCH] Stop useless updating of app compat warning --- compat/notify.go | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/compat/notify.go b/compat/notify.go index dea8b394..ea9a9c16 100644 --- a/compat/notify.go +++ b/compat/notify.go @@ -148,14 +148,23 @@ func (issue *appIssue) notify(proc *process.Process) { // Set warning on profile. module.StartWorker("set app compat warning", func(ctx context.Context) error { + var changed bool + func() { p.Lock() defer p.Unlock() - p.Warning = fmt.Sprintf(issue.message, p.Name) - p.WarningLastUpdated = time.Now() + warningMsg := fmt.Sprintf(issue.message, p.Name) + if p.Warning != warningMsg || time.Now().Add(-1*time.Hour).After(p.WarningLastUpdated) { + p.Warning = warningMsg + p.WarningLastUpdated = time.Now() + changed = true + } }() - return p.Save() + if changed { + return p.Save() + } + return nil }) }