Revamp profile and process handling

Also, introduce the Internal flag to Profiles

profile/active.go

@@ -7,46 +7,61 @@ import (
 )
 
 const (
-	activeProfileCleanerTickDuration = 10 * time.Minute
-	activeProfileCleanerThreshold    = 1 * time.Hour
+	activeProfileCleanerTickDuration = 1 * time.Minute
+	activeProfileCleanerThreshold    = 5 * time.Minute
 )
 
 var (
-	// TODO: periodically clean up inactive profiles
 	activeProfiles     = make(map[string]*Profile)
 	activeProfilesLock sync.RWMutex
 )
 
 // getActiveProfile returns a cached copy of an active profile and nil if it isn't found.
 func getActiveProfile(scopedID string) *Profile {
-	activeProfilesLock.Lock()
-	defer activeProfilesLock.Unlock()
+	activeProfilesLock.RLock()
+	defer activeProfilesLock.RUnlock()
 
-	profile, ok := activeProfiles[scopedID]
+	activeProfile, ok := activeProfiles[scopedID]
 	if ok {
-		return profile
+		activeProfile.MarkStillActive()
+		return activeProfile
 	}
 
 	return nil
 }
 
-// markProfileActive registers a profile as active.
-func markProfileActive(profile *Profile) {
+// findActiveProfile searched for an active local profile using the linked path.
+func findActiveProfile(linkedPath string) *Profile {
+	activeProfilesLock.RLock()
+	defer activeProfilesLock.RUnlock()
+
+	for _, activeProfile := range activeProfiles {
+		if activeProfile.LinkedPath == linkedPath {
+			activeProfile.MarkStillActive()
+			return activeProfile
+		}
+	}
+
+	return nil
+}
+
+// addActiveProfile registers a active profile.
+func addActiveProfile(profile *Profile) {
 	activeProfilesLock.Lock()
 	defer activeProfilesLock.Unlock()
 
+	profile.MarkStillActive()
 	activeProfiles[profile.ScopedID()] = profile
 }
 
-// markActiveProfileAsOutdated marks an active profile as outdated, so that it will be refetched from the database.
+// markActiveProfileAsOutdated marks an active profile as outdated.
 func markActiveProfileAsOutdated(scopedID string) {
-	activeProfilesLock.Lock()
-	defer activeProfilesLock.Unlock()
+	activeProfilesLock.RLock()
+	defer activeProfilesLock.RUnlock()
 
 	profile, ok := activeProfiles[scopedID]
 	if ok {
 		profile.outdated.Set()
-		delete(activeProfiles, scopedID)
 	}
 }
 
@@ -55,16 +70,12 @@ func cleanActiveProfiles(ctx context.Context) error {
 		select {
 		case <-time.After(activeProfileCleanerTickDuration):
 
-			threshold := time.Now().Add(-activeProfileCleanerThreshold)
+			threshold := time.Now().Add(-activeProfileCleanerThreshold).Unix()
 
 			activeProfilesLock.Lock()
 			for id, profile := range activeProfiles {
-				// get last used
-				profile.Lock()
-				lastUsed := profile.lastUsed
-				profile.Unlock()
-				// remove if not used for a while
-				if lastUsed.Before(threshold) {
+				// Remove profile if it hasn't been used for a while.
+				if profile.LastActive() < threshold {
 					profile.outdated.Set()
 					delete(activeProfiles, id)
 				}