github/portmaster
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Improve logging

Browse Source
This commit is contained in:
Daniel
2020-05-20 15:35:22 +02:00
parent 1c5474bdcd
commit 4671535691
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
firewall/master.go
View File

@@ -36,7 +36,7 @@ import (
func DecideOnConnection(conn *network.Connection, pkt packet.Packet) { func DecideOnConnection(conn *network.Connection, pkt packet.Packet) {
// update profiles and check if communication needs reevaluation // update profiles and check if communication needs reevaluation
if conn.UpdateAndCheck() { if conn.UpdateAndCheck() {
log.Infof("filter: re-evaluating verdict on %s", conn) log.Tracer(pkt.Ctx()).Infof("filter: re-evaluating verdict on %s", conn)
conn.Verdict = network.VerdictUndecided conn.Verdict = network.VerdictUndecided
if conn.Entity != nil { if conn.Entity != nil {
@@ -71,10 +71,10 @@ func DecideOnConnection(conn *network.Connection, pkt packet.Packet) {
// checkPortmasterConnection allows all connection that originate from // checkPortmasterConnection allows all connection that originate from
// portmaster itself. // portmaster itself.
func checkPortmasterConnection(conn *network.Connection, _ packet.Packet) bool { func checkPortmasterConnection(conn *network.Connection, pkt packet.Packet) bool {
// grant self // grant self
if conn.Process().Pid == os.Getpid() { if conn.Process().Pid == os.Getpid() {
log.Infof("filter: granting own connection %s", conn) log.Tracer(pkt.Ctx()).Infof("filter: granting own connection %s", conn)
conn.Verdict = network.VerdictAccept conn.Verdict = network.VerdictAccept
conn.Internal = true conn.Internal = true
return true return true
@@ -101,12 +101,12 @@ func checkSelfCommunication(conn *network.Connection, pkt packet.Packet) bool {
DstPort: pktInfo.DstPort, DstPort: pktInfo.DstPort,
}) })
if err != nil { if err != nil {
log.Warningf("filter: failed to find local peer process PID: %s", err) log.Tracer(pkt.Ctx()).Warningf("filter: failed to find local peer process PID: %s", err)
} else { } else {
// get primary process // get primary process
otherProcess, err := process.GetOrFindPrimaryProcess(pkt.Ctx(), otherPid) otherProcess, err := process.GetOrFindPrimaryProcess(pkt.Ctx(), otherPid)
if err != nil { if err != nil {
log.Warningf("filter: failed to find load local peer process with PID %d: %s", otherPid, err) log.Tracer(pkt.Ctx()).Warningf("filter: failed to find load local peer process with PID %d: %s", otherPid, err)
} else if otherProcess.Pid == conn.Process().Pid { } else if otherProcess.Pid == conn.Process().Pid {
conn.Accept("connection to self") conn.Accept("connection to self")
conn.Internal = true conn.Internal = true
@@ -233,7 +233,7 @@ func checkBypassPrevention(conn *network.Connection, _ packet.Packet) bool {
return false return false
} }
func checkFilterLists(conn *network.Connection, _ packet.Packet) bool { func checkFilterLists(conn *network.Connection, pkt packet.Packet) bool {
// apply privacy filter lists // apply privacy filter lists
p := conn.Process().Profile() p := conn.Process().Profile()
@@ -245,7 +245,7 @@ func checkFilterLists(conn *network.Connection, _ packet.Packet) bool {
case endpoints.NoMatch: case endpoints.NoMatch:
// nothing to do // nothing to do
default: default:
log.Debugf("filter: filter lists returned unsupported verdict: %s", result) log.Tracer(pkt.Ctx()).Debugf("filter: filter lists returned unsupported verdict: %s", result)
} }
return false return false
} }