From 47f4627f1f432d2e77ba457cfe5c0f00dd13697a Mon Sep 17 00:00:00 2001 From: Patrick Pacher Date: Wed, 8 Apr 2020 20:48:49 +0200 Subject: [PATCH] Close HTTP response body before client reuse --- netenv/online-status.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/netenv/online-status.go b/netenv/online-status.go index a9880844..dd17c05f 100644 --- a/netenv/online-status.go +++ b/netenv/online-status.go @@ -326,6 +326,8 @@ func checkOnlineStatus(ctx context.Context) { // this might be a weird captive portal, just direct the user there updateOnlineStatus(StatusPortal, "detectportal.firefox.com", "http request succeeded, response content not as expected") } + // close the body now as we plan to re-uise the http.Client + response.Body.Close() // 3) try a https request @@ -339,7 +341,7 @@ func checkOnlineStatus(ctx context.Context) { response, err = client.Do(request) if err != nil { // if we fail, something is really weird - updateOnlineStatus(StatusSemiOnline, "", "http request failed") + updateOnlineStatus(StatusSemiOnline, "", "http request failed to "+parsedHTTPSTestURL.String()+" with error "+err.Error()) return } defer response.Body.Close()