Fix tests and linters

compat/callbacks.go

@@ -7,6 +7,7 @@ import (
 	"github.com/safing/portmaster/process"
 )
 
+// SubmitSystemIntegrationCheckPacket submit a packet for the system integrity check.
 func SubmitSystemIntegrationCheckPacket(p packet.Packet) {
 	select {
 	case systemIntegrationCheckPackets <- p:
@@ -14,6 +15,7 @@ func SubmitSystemIntegrationCheckPacket(p packet.Packet) {
 	}
 }
 
+// SubmitDNSCheckDomain submits a subdomain for the dns check.
 func SubmitDNSCheckDomain(subdomain string) (respondWith net.IP) {
 	// Submit queried domain.
 	select {
@@ -27,10 +29,12 @@ func SubmitDNSCheckDomain(subdomain string) (respondWith net.IP) {
 	return dnsCheckAnswer
 }
 
+// ReportSecureDNSBypassIssue reports a DNS bypassing issue for the given process.
 func ReportSecureDNSBypassIssue(p *process.Process) {
 	secureDNSBypassIssue.notify(p)
 }
 
+// ReportMultiPeerUDPTunnelIssue reports a multi-peer UDP tunnel for the given process.
 func ReportMultiPeerUDPTunnelIssue(p *process.Process) {
 	multiPeerUDPTunnelIssue.notify(p)
 }

compat/module.go

@@ -4,11 +4,12 @@ import (
 	"context"
 	"time"
 
+	"github.com/tevino/abool"
+
 	"github.com/safing/portbase/log"
 	"github.com/safing/portbase/modules"
 	"github.com/safing/portmaster/netenv"
 	"github.com/safing/portmaster/resolver"
-	"github.com/tevino/abool"
 )
 
 var (
@@ -43,7 +44,7 @@ func prep() error {
 
 func start() error {
 	selfcheckTask = module.NewTask("compatibility self-check", selfcheckTaskFunc).
-		Repeat(1 * time.Minute).
+		Repeat(5 * time.Minute).
 		MaxDelay(selfcheckTaskRetryAfter).
 		Schedule(time.Now().Add(selfcheckTaskRetryAfter))
 
@@ -98,6 +99,9 @@ func selfcheckTaskFunc(ctx context.Context, task *modules.Task) error {
 	return nil
 }
 
+// SelfCheckIsFailing returns whether the self check is currently failing.
+// This returns true after the first check fails, and does not wait for the
+// failing threshold to be met.
 func SelfCheckIsFailing() bool {
 	return selfCheckIsFailing.IsSet()
 }

compat/notify.go

@@ -7,18 +7,17 @@ import (
 	"sync"
 	"time"
 
-	"github.com/safing/portmaster/profile"
-
 	"github.com/safing/portbase/log"
 	"github.com/safing/portbase/notifications"
 	"github.com/safing/portmaster/process"
+	"github.com/safing/portmaster/profile"
 )
 
 type baseIssue struct {
-	id      string
-	title   string
-	message string
-	level   notifications.Type
+	id      string             //nolint:structcheck // Inherited.
+	title   string             //nolint:structcheck // Inherited.
+	message string             //nolint:structcheck // Inherited.
+	level   notifications.Type //nolint:structcheck // Inherited.
 }
 
 type systemIssue baseIssue

compat/selfcheck.go

@@ -18,22 +18,24 @@ import (
 var (
 	selfcheckLock sync.Mutex
 
-	SystemIntegrationCheckDstIP    = net.IPv4(127, 65, 67, 75)
+	// SystemIntegrationCheckDstIP is the IP address to send a packet to for the
+	// system integration test.
+	SystemIntegrationCheckDstIP = net.IPv4(127, 65, 67, 75)
+	// SystemIntegrationCheckProtocol is the IP protocol to use for the system
+	// integration test.
 	SystemIntegrationCheckProtocol = packet.AnyHostInternalProtocol61
 
 	systemIntegrationCheckDialNet      = fmt.Sprintf("ip4:%d", uint8(SystemIntegrationCheckProtocol))
 	systemIntegrationCheckDialIP       = SystemIntegrationCheckDstIP.String()
 	systemIntegrationCheckPackets      = make(chan packet.Packet, 1)
-	systemIntegrationCheckWaitDuration = 3 * time.Second
+	systemIntegrationCheckWaitDuration = 10 * time.Second
 
+	// DNSCheckInternalDomainScope is the domain scope to use for dns checks.
 	DNSCheckInternalDomainScope = ".self-check." + resolver.InternalSpecialUseDomain
 	dnsCheckReceivedDomain      = make(chan string, 1)
-	dnsCheckWaitDuration        = 3 * time.Second
+	dnsCheckWaitDuration        = 10 * time.Second
 	dnsCheckAnswerLock          sync.Mutex
 	dnsCheckAnswer              net.IP
-
-	DNSTestDomain     = "one.one.one.one."
-	DNSTestExpectedIP = net.IPv4(1, 1, 1, 1)
 )
 
 func selfcheck(ctx context.Context) (issue *systemIssue, err error) {