Fix tests and linters

network/netutils/address.go

@@ -19,7 +19,7 @@ func IPFromAddr(addr net.Addr) (net.IP, error) {
 		// Parse via string.
 		host, _, err := net.SplitHostPort(addr.String())
 		if err != nil {
-			return nil, fmt.Errorf("failed to split host and port of %q: %s", addr, err)
+			return nil, fmt.Errorf("failed to split host and port of %q: %w", addr, err)
 		}
 		ip := net.ParseIP(host)
 		if ip == nil {

network/netutils/dns.go

@@ -8,19 +8,17 @@ import (
 	"github.com/miekg/dns"
 )
 
-var (
-	cleanDomainRegex = regexp.MustCompile(
-		`^` + // match beginning
-			`(` + // start subdomain group
-			`(xn--)?` + // idn prefix
-			`[a-z0-9_-]{1,63}` + // main chunk
-			`\.` + // ending with a dot
-			`)*` + // end subdomain group, allow any number of subdomains
-			`(xn--)?` + // TLD idn prefix
-			`[a-z0-9_-]{2,63}` + // TLD main chunk with at least two characters
-			`\.` + // ending with a dot
-			`$`, // match end
-	)
+var cleanDomainRegex = regexp.MustCompile(
+	`^` + // match beginning
+		`(` + // start subdomain group
+		`(xn--)?` + // idn prefix
+		`[a-z0-9_-]{1,63}` + // main chunk
+		`\.` + // ending with a dot
+		`)*` + // end subdomain group, allow any number of subdomains
+		`(xn--)?` + // TLD idn prefix
+		`[a-z0-9_-]{2,63}` + // TLD main chunk with at least two characters
+		`\.` + // ending with a dot
+		`$`, // match end
 )
 
 // IsValidFqdn returns whether the given string is a valid fqdn.

network/netutils/dns_test.go

@@ -3,12 +3,16 @@ package netutils
 import "testing"
 
 func testDomainValidity(t *testing.T, domain string, isValid bool) {
+	t.Helper()
+
 	if IsValidFqdn(domain) != isValid {
 		t.Errorf("domain %s failed check: was valid=%v, expected valid=%v", domain, IsValidFqdn(domain), isValid)
 	}
 }
 
 func TestDNSValidation(t *testing.T) {
+	t.Parallel()
+
 	// valid
 	testDomainValidity(t, ".", true)
 	testDomainValidity(t, "at.", true)

network/netutils/ip.go

@@ -93,7 +93,7 @@ func (scope IPScope) IsLocalhost() bool {
 
 // IsLAN returns true if the scope is site-local or link-local.
 func (scope IPScope) IsLAN() bool {
-	switch scope {
+	switch scope { //nolint:exhaustive // Looking for something specific.
 	case SiteLocal, LinkLocal, LocalMulticast:
 		return true
 	default:
@@ -103,7 +103,7 @@ func (scope IPScope) IsLAN() bool {
 
 // IsGlobal returns true if the scope is global.
 func (scope IPScope) IsGlobal() bool {
-	switch scope {
+	switch scope { //nolint:exhaustive // Looking for something specific.
 	case Global, GlobalMulticast:
 		return true
 	default:

network/netutils/ip_test.go

@@ -6,6 +6,8 @@ import (
 )
 
 func TestIPScope(t *testing.T) {
+	t.Parallel()
+
 	testScope(t, net.IPv4(71, 87, 113, 211), Global)
 	testScope(t, net.IPv4(127, 0, 0, 1), HostLocal)
 	testScope(t, net.IPv4(127, 255, 255, 1), HostLocal)
@@ -17,6 +19,8 @@ func TestIPScope(t *testing.T) {
 }
 
 func testScope(t *testing.T, ip net.IP, expectedScope IPScope) {
+	t.Helper()
+
 	c := GetIPScope(ip)
 	if c != expectedScope {
 		t.Errorf("%s is %s, expected %s", ip, scopeName(c), scopeName(expectedScope))

network/netutils/tcpassembly.go

@@ -7,7 +7,7 @@ import (
 	"github.com/google/gopacket/tcpassembly"
 )
 
-// SimpleStreamAssemblerManager is a simple manager for github.com/google/gopacket/tcpassembly
+// SimpleStreamAssemblerManager is a simple manager for github.com/google/gopacket/tcpassembly.
 type SimpleStreamAssemblerManager struct {
 	InitLock      sync.Mutex
 	lastAssembler *SimpleStreamAssembler
@@ -25,7 +25,7 @@ func (m *SimpleStreamAssemblerManager) GetLastAssembler() *SimpleStreamAssembler
 	return m.lastAssembler
 }
 
-// SimpleStreamAssembler is a simple assembler for github.com/google/gopacket/tcpassembly
+// SimpleStreamAssembler is a simple assembler for github.com/google/gopacket/tcpassembly.
 type SimpleStreamAssembler struct {
 	Cumulated    []byte
 	CumulatedLen int