This commit is contained in:
Daniel
2024-11-27 16:16:15 +01:00
parent f91003d077
commit 706ce222d0
35 changed files with 1138 additions and 601 deletions

View File

@@ -238,13 +238,13 @@ export class EditProfileDialog implements OnInit, OnDestroy {
this.portapi.delete(icon.Value).subscribe();
}
// FIXME(ppacher): we cannot yet delete API based icons ...
// TODO(ppacher): we cannot yet delete API based icons ...
});
if (this.iconData !== '') {
// save the new icon in the cache database
// FIXME(ppacher): we currently need to calls because the icon API in portmaster
// TODO(ppacher): we currently need to calls because the icon API in portmaster
// does not update the profile but just saves the file and returns the filename.
// So we still need to update the profile manually.
updateIcon = this.profileService
@@ -261,7 +261,7 @@ export class EditProfileDialog implements OnInit, OnDestroy {
})
);
// FIXME(ppacher): reset presentationpath
// TODO(ppacher): reset presentationpath
} else {
// just clear out that there was an icon
this.profile.Icons = [];

View File

@@ -543,7 +543,7 @@ export class SfngNetqueryLineChartComponent<D extends SeriesData = any> implemen
.append("title")
.text(d => d.text)
// FIXME(ppacher): somehow d3 does not recognize which data points must be removed
// TODO(ppacher): somehow d3 does not recognize which data points must be removed
// or re-placed. For now, just remove them all
this.svgInner
.select('.points')

View File

@@ -184,7 +184,7 @@ export class SfngNetquerySearchbarComponent implements ControlValueAccessor, OnI
const queries: Observable<SfngSearchbarSuggestion<any>>[] = [];
const queryKeys: (keyof Partial<NetqueryConnection>)[] = [];
// FIXME(ppacher): confirm .type is an actually allowed field
// TODO(ppacher): confirm .type is an actually allowed field
if (!!parser.lastUnterminatedCondition) {
fields = [parser.lastUnterminatedCondition.type as keyof NetqueryConnection];
limit = 0;