Restructure modules (#1572)

* Move portbase into monorepo

* Add new simple module mgr

* [WIP] Switch to new simple module mgr

* Add StateMgr and more worker variants

* [WIP] Switch more modules

* [WIP] Switch more modules

* [WIP] swtich more modules

* [WIP] switch all SPN modules

* [WIP] switch all service modules

* [WIP] Convert all workers to the new module system

* [WIP] add new task system to module manager

* [WIP] Add second take for scheduling workers

* [WIP] Add FIXME for bugs in new scheduler

* [WIP] Add minor improvements to scheduler

* [WIP] Add new worker scheduler

* [WIP] Fix more bug related to new module system

* [WIP] Fix start handing of the new module system

* [WIP] Improve startup process

* [WIP] Fix minor issues

* [WIP] Fix missing subsystem in settings

* [WIP] Initialize managers in constructor

* [WIP] Move module event initialization to constrictors

* [WIP] Fix setting for enabling and disabling the SPN module

* [WIP] Move API registeration into module construction

* [WIP] Update states mgr for all modules

* [WIP] Add CmdLine operation support

* Add state helper methods to module group and instance

* Add notification and module status handling to status package

* Fix starting issues

* Remove pilot widget and update security lock to new status data

* Remove debug logs

* Improve http server shutdown

* Add workaround for cleanly shutting down firewall+netquery

* Improve logging

* Add syncing states with notifications for new module system

* Improve starting, stopping, shutdown; resolve FIXMEs/TODOs

* [WIP] Fix most unit tests

* Review new module system and fix minor issues

* Push shutdown and restart events again via API

* Set sleep mode via interface

* Update example/template module

* [WIP] Fix spn/cabin unit test

* Remove deprecated UI elements

* Make log output more similar for the logging transition phase

* Switch spn hub and observer cmds to new module system

* Fix log sources

* Make worker mgr less error prone

* Fix tests and minor issues

* Fix observation hub

* Improve shutdown and restart handling

* Split up big connection.go source file

* Move varint and dsd packages to structures repo

* Improve expansion test

* Fix linter warnings

* Fix interception module on windows

* Fix linter errors

---------

Co-authored-by: Vladimir Stoilov <vladimir@safing.io>

spn/terminal/session_test.go

@@ -16,7 +16,7 @@ func TestRateLimit(t *testing.T) {
 	s := NewSession()
 
 	// Everything should be okay within the min limit.
-	for i := 0; i < rateLimitMinOps; i++ {
+	for range rateLimitMinOps {
 		tErr = s.RateLimit()
 		if tErr != nil {
 			t.Error("should not rate limit within min limit")
@@ -24,7 +24,7 @@ func TestRateLimit(t *testing.T) {
 	}
 
 	// Somewhere here we should rate limiting.
-	for i := 0; i < rateLimitMaxOpsPerSecond; i++ {
+	for range rateLimitMaxOpsPerSecond {
 		tErr = s.RateLimit()
 	}
 	assert.ErrorIs(t, tErr, ErrRateLimited, "should rate limit")
@@ -37,7 +37,7 @@ func TestSuspicionLimit(t *testing.T) {
 	s := NewSession()
 
 	// Everything should be okay within the min limit.
-	for i := 0; i < rateLimitMinSuspicion; i++ {
+	for range rateLimitMinSuspicion {
 		tErr = s.RateLimit()
 		if tErr != nil {
 			t.Error("should not rate limit within min limit")
@@ -46,7 +46,7 @@ func TestSuspicionLimit(t *testing.T) {
 	}
 
 	// Somewhere here we should rate limiting.
-	for i := 0; i < rateLimitMaxSuspicionPerSecond; i++ {
+	for range rateLimitMaxSuspicionPerSecond {
 		s.ReportSuspiciousActivity(SusFactorCommon)
 		tErr = s.RateLimit()
 	}
@@ -66,8 +66,7 @@ func TestConcurrencyLimit(t *testing.T) {
 
 	// Start many workers to test concurrency.
 	wg.Add(workers)
-	for i := 0; i < workers; i++ {
-		workerNum := i
+	for workerNum := range workers {
 		go func() {
 			defer func() {
 				_ = recover()