github/portmaster
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Increase verbosity, add comments

Browse Source
This commit is contained in:
Raskaro
2019-08-21 14:19:02 +02:00
parent 984a06cb8f
commit a560f52b42
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
firewall/firewall.go
View File

@@ -146,6 +146,7 @@ func handlePacket(pkt packet.Packet) {
pkt.PermanentAccept() pkt.PermanentAccept()
return return
} }
// TODO: Howto handle NetBios?
} }
// log.Debugf("firewall: pkt %s has ID %s", pkt, pkt.GetLinkID()) // log.Debugf("firewall: pkt %s has ID %s", pkt, pkt.GetLinkID())
@@ -268,8 +269,9 @@ func initialHandler(pkt packet.Packet, link *network.Link) {
// link.StopFirewallHandler() // link.StopFirewallHandler()
// permanentVerdict(pkt, network.VerdictAccept) // permanentVerdict(pkt, network.VerdictAccept)
case link.Inspect: case link.Inspect:
log.Tracer(pkt.Ctx()).Trace("firewall: start inspecting")
link.SetFirewallHandler(inspectThenVerdict) link.SetFirewallHandler(inspectThenVerdict)
inspectThenVerdict(pkt, link) inspectThenVerdict(pkt, link) // TODO: corrent?: concurrently also called in link.SetFirewallHandler->go link.packetHandler()->fwH(pkt, link)
default: default:
link.StopFirewallHandler() link.StopFirewallHandler()
issueVerdict(pkt, link, 0, true) issueVerdict(pkt, link, 0, true)

2
firewall/inspection/inspection.go
View File

@@ -64,7 +64,7 @@ func RunInspectors(pkt packet.Packet, link *network.Link) (network.Verdict, bool
continue continue
} }
action := inspectors[key](pkt, link) action := inspectors[key](pkt, link) // Actually run inspector
switch action { switch action {
case DO_NOTHING: case DO_NOTHING:
if verdict < network.VerdictAccept { if verdict < network.VerdictAccept {