From b94adf17c1d73e2cfbd1f399b8408aab74c9e05f Mon Sep 17 00:00:00 2001 From: Daniel Date: Wed, 17 Nov 2021 14:10:11 +0100 Subject: [PATCH] Improve resolver failing reporting --- resolver/resolver-tcp.go | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/resolver/resolver-tcp.go b/resolver/resolver-tcp.go index 30ff20a2..78968da8 100644 --- a/resolver/resolver-tcp.go +++ b/resolver/resolver-tcp.go @@ -145,10 +145,16 @@ func (tr *TCPResolver) getOrCreateResolverConn(ctx context.Context) (*tcpResolve // Connect to server. conn, err := tr.dnsClient.Dial(tr.resolver.ServerAddress) if err != nil { - log.Debugf("resolver: failed to connect to %s", tr.resolver.Info.DescriptiveName()) + // Hint network environment at failed connection. + netenv.ReportFailedConnection() + + log.Debugf("resolver: failed to connect to %s: %s", tr.resolver.Info.DescriptiveName(), err) return nil, fmt.Errorf("%w: failed to connect to %s: %s", ErrFailure, tr.resolver.Info.DescriptiveName(), err) } + // Hint network environment at successful connection. + netenv.ReportSuccessfulConnection() + // Log that a connection to the resolver was established. log.Debugf( "resolver: connected to %s", @@ -174,9 +180,6 @@ func (tr *TCPResolver) getOrCreateResolverConn(ctx context.Context) (*tcpResolve // Set resolver conn for reuse. tr.resolverConn = resolverConn - // Hint network environment at successful connection. - netenv.ReportSuccessfulConnection() - return resolverConn, nil }