Merge pull request #202 from safing/fix/windows-iphlp-bufsize

Increase max iphlp buffer size

network/iphelper/tables.go

@@ -97,13 +97,20 @@ const (
 
 const (
 	startBufSize = 4096
-	bufSizeUses  = 100
+
+	// bufSizeUsageTTL defines how often a buffer size is used before it is
+	// shrunk again.
+	bufSizeUsageTTL = 100
+
+	// maxBufSize is the maximum size we will allocate for responses. This was
+	// previously set at 65k, which was too little for some production cases.
+	maxBufSize = 1048576 // 2^20B, 1MB
 )
 
 var (
-	bufSize          = startBufSize
+	bufSize         = startBufSize
-	bufSizeUsageLeft = bufSizeUses
+	bufSizeUsesLeft = bufSizeUsageTTL
-	bufSizeLock      sync.Mutex
+	bufSizeLock     sync.Mutex
 )
 
 func getBufSize() int {
@@ -111,12 +118,17 @@ func getBufSize() int {
 	defer bufSizeLock.Unlock()
 
 	// using bufSize
-	bufSizeUsageLeft--
+	bufSizeUsesLeft--
 	// check if we want to reset
-	if bufSizeUsageLeft <= 0 {
+	if bufSizeUsesLeft <= 0 {
-		// reset
+		// decrease
-		bufSize = startBufSize
+		bufSize /= 2
-		bufSizeUsageLeft = bufSizeUses
+		// not too little
+		if bufSize < startBufSize {
+			bufSize = startBufSize
+		}
+		// reset counter
+		bufSizeUsesLeft = bufSizeUsageTTL
 	}
 
 	return bufSize
@@ -129,11 +141,11 @@ func increaseBufSize() int {
 	// increase
 	bufSize *= 2
 	// not too much
-	if bufSize > 65536 {
+	if bufSize > maxBufSize {
-		bufSize = 65536
+		bufSize = maxBufSize
 	}
 	// reset
-	bufSizeUsageLeft = bufSizeUses
+	bufSizeUsesLeft = bufSizeUsageTTL
 	// return new bufSize
 	return bufSize
 }