diff --git a/desktop/angular/src/app/pages/app-view/app-view.html b/desktop/angular/src/app/pages/app-view/app-view.html index 0bba8b7b..72a7ad81 100644 --- a/desktop/angular/src/app/pages/app-view/app-view.html +++ b/desktop/angular/src/app/pages/app-view/app-view.html @@ -3,7 +3,7 @@
- Apps +
Apps
diff --git a/desktop/angular/src/main.ts b/desktop/angular/src/main.ts index 1d83337d..f6fc9b2c 100644 --- a/desktop/angular/src/main.ts +++ b/desktop/angular/src/main.ts @@ -27,9 +27,15 @@ if (typeof (CSS as any)['registerProperty'] === 'function') { } function handleExternalResources(e: Event) { + // TODO: + // This code executes "openExternal()" when any "" element in the app is clicked. + // This could potentially be a security issue. + // We should consider restricting this to only external links that belong to a certain domain (e.g., https://safing.io). + // get click target let target: HTMLElement | null = e.target as HTMLElement; - // traverse until we reach an a tag + + // traverse until we reach element "" while (!!target && target.tagName !== "A") { target = target.parentElement; }