github/svgedit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

- Refactoring: Reorder path config to group (non-modular-dependent) image

Browse Source 
paths together (and correct code comment)
- Docs: CHANGES clarifications/fixes
- Docs: Migrations documents section
- Docs: Add code comment re: use of `extIconsPath` in Mathjax
- Docs: Add JSDoc indicate @this for `ExtensionInitResponse#callback`
- Build: Update build files
- npm: Bump to 3.1.0
This commit is contained in:
Brett Zamir
2018-10-23 18:35:49 +08:00
parent 9d454d79fd
commit 07f59ba01a
17 changed files with 539 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
editor/extensions/ext-mathjax.js
View File

@@ -189,6 +189,8 @@ export default {
svgEditor.curConfig.extIconsPath + mathjaxSrcSecure
);
*/
// We use `extIconsPath` here for now as it does not vary with
// the modular type as does `extPath`
importScript(svgEditor.curConfig.extIconsPath + mathjaxSrcSecure).then(() => {
// When MathJax is loaded get the div where the math will be rendered.
MathJax.Hub.queue.Push(function () {

14
editor/svg-editor.js
View File

@@ -243,13 +243,13 @@ const callbacks = [],
no_save_warning: false,
// PATH CONFIGURATION
// The following path configuration items are disallowed in the URL (as should any future path configurations)
langPath: 'locale/', // Default will be changed if this is a non-modular load
extPath: 'extensions/', // Default will be changed if this is a non-modular load
canvgPath: 'canvg/', // Default will be changed if this is a non-modular load
jspdfPath: 'jspdf/', // Default will be changed if this is a non-modular load
imgPath: 'images/',
langPath: 'locale/', // Default will be changed if this is a modular load
extPath: 'extensions/', // Default will be changed if this is a modular load
canvgPath: 'canvg/', // Default will be changed if this is a modular load
jspdfPath: 'jspdf/', // Default will be changed if this is a modular load
extIconsPath: 'extensions/',
jGraduatePath: 'jgraduate/images/',
extIconsPath: 'extensions/',
// DOCUMENT PROPERTIES
// Change the following to a preference (already in the Document Properties dialog)?
dimensions: [640, 480],
@@ -703,8 +703,8 @@ editor.init = function () {
// ones given potential to interact in undesirable
// ways with other script resources
[
'extPath', 'imgPath', 'extIconsPath', 'canvgPath',
'langPath', 'jGraduatePath', 'jspdfPath'
'langPath', 'extPath', 'canvgPath', 'jspdfPath',
'imgPath', 'jGraduatePath', 'extIconsPath'
].forEach(function (pathConfig) {
if (urldata[pathConfig]) {
delete urldata[pathConfig];

1
editor/svgcanvas.js
View File

@@ -1102,6 +1102,7 @@ const runExtensions = this.runExtensions = function (action, vars, returnArray)
*/
/**
* @function module:svgcanvas.ExtensionInitResponse#callback
* @this module:SVGEditor
* @param {module:svgcanvas.SvgCanvas#event:ext-callback} arg
* @returns {undefined}
*/

15
editor/xdomain-svgedit-config-iife.js
View File

@@ -14297,6 +14297,7 @@
/**
* @function module:svgcanvas.ExtensionInitResponse#callback
* @this module:SVGEditor
* @param {module:svgcanvas.SvgCanvas#event:ext-callback} arg
* @returns {undefined}
*/
@@ -27727,17 +27728,17 @@
no_save_warning: false,
// PATH CONFIGURATION
// The following path configuration items are disallowed in the URL (as should any future path configurations)
imgPath: 'images/',
langPath: 'locale/',
// Default will be changed if this is a modular load
// Default will be changed if this is a non-modular load
extPath: 'extensions/',
// Default will be changed if this is a modular load
// Default will be changed if this is a non-modular load
canvgPath: 'canvg/',
// Default will be changed if this is a modular load
// Default will be changed if this is a non-modular load
jspdfPath: 'jspdf/',
// Default will be changed if this is a modular load
extIconsPath: 'extensions/',
// Default will be changed if this is a non-modular load
imgPath: 'images/',
jGraduatePath: 'jgraduate/images/',
extIconsPath: 'extensions/',
// DOCUMENT PROPERTIES
// Change the following to a preference (already in the Document Properties dialog)?
dimensions: [640, 480],
@@ -28278,7 +28279,7 @@
// ways with other script resources
['extPath', 'imgPath', 'extIconsPath', 'canvgPath', 'langPath', 'jGraduatePath', 'jspdfPath'].forEach(function (pathConfig) {
['langPath', 'extPath', 'canvgPath', 'jspdfPath', 'imgPath', 'jGraduatePath', 'extIconsPath'].forEach(function (pathConfig) {
if (urldata[pathConfig]) {
delete urldata[pathConfig];
}