github/svgedit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

#599 InternalError: too much recursion issue partially fixed

Browse Source
This commit is contained in:
agriyadev5
2021-08-17 13:19:12 +05:30
parent 2860528211
commit 0b79020a9b
5 changed files with 39 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/editor/components/seSpinInput.js
View File

@@ -183,7 +183,7 @@ export class SESpinInput extends HTMLElement {
connectedCallback () {
this.$input.addEventListener('onchange', (e) => {
e.preventDefault();
if(e.detail !== this.value && e.detail !== "") {
if(e.detail !== this.value && e.detail !== "" && !isNaN(e.detail) ) {
const event = new CustomEvent('change', { detail: e.detail });
this.dispatchEvent(event);
}

10
src/editor/panels/BottomPanel.js
View File

@@ -134,8 +134,14 @@ class BottomPanel {
* @type {module}
*/
handleOpacity (evt) {
const val = Number.parseInt(evt.currentTarget.value.split('%')[0]);
this.editor.svgCanvas.setOpacity(val / 100);
let val = evt.currentTarget.value;
if(evt.detail !== undefined) {
val = evt.detail;
}
val = Number.parseInt(val.split('%')[0]);
if(!isNaN(val)) {
this.editor.svgCanvas.setOpacity(val / 100);
}
}
/**
* @type {module}

31
src/editor/panels/TopPanel.js
View File

@@ -497,23 +497,35 @@ class TopPanel {
* @type {module}
*/
changeRectRadius(e) {
this.editor.svgCanvas.setRectRadius(e.target.value);
let val = e.target.value;
if(e.detail !== undefined) {
val = e.detail;
}
this.editor.svgCanvas.setRectRadius(val);
}
/**
* @type {module}
*/
changeFontSize(e) {
this.editor.svgCanvas.setFontSize(e.target.value);
let val = e.target.value;
if(e.detail !== undefined) {
val = e.detail;
}
this.editor.svgCanvas.setFontSize(val);
}
/**
* @type {module}
*/
changeRotationAngle(e) {
this.editor.svgCanvas.setRotationAngle(e.target.value);
let val = e.target.value;
if(e.detail !== undefined) {
val = e.detail;
}
this.editor.svgCanvas.setRotationAngle(val);
// eslint-disable-next-line max-len
(Number.parseInt(e.target.value) === 0) ? $id("tool_reorient").classList.add("disabled") : $id("tool_reorient").classList.remove("disabled");
(Number.parseInt(val) === 0) ? $id("tool_reorient").classList.add("disabled") : $id("tool_reorient").classList.remove("disabled");
}
/**
@@ -521,7 +533,11 @@ class TopPanel {
* @returns {void}
*/
changeBlur(e) {
this.editor.svgCanvas.setBlur(e.target.value / 10, true);
let val = e.target.value;
if(e.detail !== undefined) {
val = e.detail;
}
this.editor.svgCanvas.setBlur(val / 10, true);
}
/**
*
@@ -570,7 +586,10 @@ class TopPanel {
*/
attrChanger(e) {
const attr = e.target.getAttribute("data-attr");
let val = (e.detail || e.target.value);
let val = e?.target?.value;
if(e.detail !== undefined) {
val = e.detail;
}
const valid = isValidUnit(attr, val, this.selectedElement);
if (!valid) {