- Breaking change: loadSvgString now returns a Promise rather than accepting a callback

- Breaking change: Treat callbacks to `editor.ready` as Promises, only resolving after all resolve
- Breaking change: Make `editor.runCallbacks` return a `Promise` which resolves upon all callbacks resolving
- Breaking change: Require `npx` (used with `babel-node`) to allow Node files
  for HTML building and JSDoc type checking to be expressed as ESM.
- Breaking change: `addExtension` now throws upon a repeated attempt to add an already-added extension
- Breaking change (storage preference cookies): Namespace the cookie as "svgeditstore" instead of just "store"
- Breaking change (API): Remove `svgCanvas.rasterExport` fourth (callback) argument, collapsing fifth (options) to fourth
- Breaking change (API): Remove `svgCanvas.exportPDF` third (callback) argument
- Breaking change (API): `editor/contextmenu.js` `add` now throws instead of giving a console error only upon detecting a bad menuitem or preexisting context menu
- Breaking change (API): Remove `svgCanvas.embedImage` second (callback) argument
- Breaking change (API): Make `getHelpXML` a class instead of instance method of `RGBColor`
- Breaking change (internal API): Refactor `dbox` (and `alert`/`confirm`/`process`/`prompt`/`select`) to avoid a callback argument in favor of return a Promise
- Fix: Avoid running in extension `langReady` multiple times or serially
- Enhancement (API): Add svgCanvas.runExtension to run just one extension and add `nameFilter` callback to `runExtensions`
- Enhancement (API): Supply `$` (our wrapped jQuery) to extensions so can use its plugins, e.g., dbox with its `alert`
- Enhancement: Use alert dialog in place of `alert` in webappfind
- Enhancement: `editor.ready` now returns a Promise resolving when all callbacks have resolved
- Enhancement: Allow `noAlert` option as part of second argument to `loadSvgString` (and `loadFromURL` and `loadFromDataURI`) to avoid UI alert (and trigger promise rejection)
- Enhancement: Make `dbox` as a separate module for alert, prompt, etc. dialogs
- Refactoring: Internal `PaintBox` as class; other misc. tweaks; no bitwise in canvg
- Linting (ESLint): Further linting changes (for editor); rename `.eslintrc` -> `.eslintrc.json` per recommendation
- Optimization: Recompress images (imageoptim-cli updated)
- npm: Update devDeps
- npm: Bump to 4.0.0

editor/extensions/ext-connector.js

@@ -1,4 +1,3 @@
-/* globals jQuery */
 /**
  * ext-connector.js
  *
@@ -11,11 +10,10 @@
 export default {
   name: 'connector',
   async init (S) {
-    const $ = jQuery;
     const svgEditor = this;
     const svgCanvas = svgEditor.canvas;
     const {getElem} = svgCanvas;
-    const {svgroot, importLocale} = S,
+    const {$, svgroot, importLocale} = S,
       addElem = svgCanvas.addSVGElementFromJson,
       selManager = S.selectorManager,
       connSel = '.se_connector',
@@ -34,6 +32,14 @@ export default {
       connections = [],
       selElems = [];
 
+    /**
+     *
+     * @param {Float} x
+     * @param {Float} y
+     * @param {module:utilities.BBoxObject} bb
+     * @param {Float} offset
+     * @returns {module:math.XYObject}
+     */
     function getBBintersect (x, y, bb, offset) {
       if (offset) {
         offset -= 0;
@@ -66,6 +72,11 @@ export default {
       };
     }
 
+    /**
+    * @param {"start"|"end"} side
+    * @param {Element} line
+    * @returns {Float}
+    */
     function getOffset (side, line) {
       const giveOffset = line.getAttribute('marker-' + side);
       // const giveOffset = $(line).data(side+'_off');
@@ -75,6 +86,10 @@ export default {
       return giveOffset ? size : 0;
     }
 
+    /**
+    * @param {boolean} on
+    * @returns {undefined}
+    */
     function showPanel (on) {
       let connRules = $('#connector_rules');
       if (!connRules.length) {
@@ -84,6 +99,14 @@ export default {
       $('#connector_panel').toggle(on);
     }
 
+    /**
+     * @param {Element} elem
+     * @param {Integer|"end"} pos
+     * @param {Float} x
+     * @param {Float} y
+     * @param {boolean} [setMid]
+     * @returns {undefined}
+    */
     function setPoint (elem, pos, x, y, setMid) {
       const pts = elem.points;
       const pt = svgroot.createSVGPoint();
@@ -112,6 +135,11 @@ export default {
       }
     }
 
+    /**
+    * @param {Float} diffX
+    * @param {Float} diffY
+    * @returns {undefined}
+    */
     function updateLine (diffX, diffY) {
       // Update line with element
       let i = connections.length;
@@ -158,6 +186,10 @@ export default {
       // Loop through connectors to see if one is connected to the element
       connectors.each(function () {
         let addThis;
+        /**
+        *
+        * @returns {undefined}
+        */
         function add () {
           if (elems.includes(this)) {
             // Pretend this element is selected
@@ -205,6 +237,10 @@ export default {
       });
     }
 
+    /**
+    * @param {Element[]} [elems=selElems]
+    * @returns {undefined}
+    */
     function updateConnectors (elems) {
       // Updates connector lines based on selected elements
       // Is not used on mousemove, as it runs getStrokedBBox every time,
@@ -278,7 +314,10 @@ export default {
       seNs = svgCanvas.getEditorNS();
     }());
 
-    // Do on reset
+    /**
+    * Do on reset.
+    * @returns {undefined}
+    */
     function init () {
       // Make sure all connectors have data set
       $(svgcontent).find('*').each(function () {
@@ -331,7 +370,7 @@ export default {
       buttons: strings.buttons.map((button, i) => {
         return Object.assign(buttons[i], button);
       }),
-      /* async */ addLangData ({lang, importLocale}) {
+      /* async */ addLangData ({lang}) { // , importLocale: importLoc
         return {
           data: strings.langList
         };
@@ -344,7 +383,7 @@ export default {
         const {curConfig: {initStroke}} = svgEditor;
 
         if (mode === 'connector') {
-          if (started) { return; }
+          if (started) { return undefined; }
 
           const mouseTarget = e.target;
 
@@ -386,6 +425,7 @@ export default {
         if (mode === 'select') {
           findConnectors();
         }
+        return undefined;
       },
       mouseMove (opts) {
         const zoom = svgCanvas.getZoom();
@@ -433,7 +473,7 @@ export default {
         let mouseTarget = e.target;
 
         if (svgCanvas.getMode() !== 'connector') {
-          return;
+          return undefined;
         }
         const fo = $(mouseTarget).closest('foreignObject');
         if (fo.length) { mouseTarget = fo[0]; }
@@ -469,6 +509,7 @@ export default {
         const dupe = $(svgcontent).find(connSel).filter(function () {
           const conn = this.getAttributeNS(seNs, 'connector');
           if (conn === connStr || conn === altStr) { return true; }
+          return false;
         });
         if (dupe.length) {
           $(curLine).remove();
@@ -596,7 +637,7 @@ export default {
 
             // Check validity - the field would be something like 'svg_21 svg_22', but
             // if one end is missing, it would be 'svg_21' and therefore fail this test
-            if (!/. ./.test(elem.attr['se:connector'])) {
+            if (!(/. ./).test(elem.attr['se:connector'])) {
               remove.push(elem.attr.id);
             }
           }