- Breaking change: loadSvgString now returns a Promise rather than accepting a callback

- Breaking change: Treat callbacks to `editor.ready` as Promises, only resolving after all resolve
- Breaking change: Make `editor.runCallbacks` return a `Promise` which resolves upon all callbacks resolving
- Breaking change: Require `npx` (used with `babel-node`) to allow Node files
  for HTML building and JSDoc type checking to be expressed as ESM.
- Breaking change: `addExtension` now throws upon a repeated attempt to add an already-added extension
- Breaking change (storage preference cookies): Namespace the cookie as "svgeditstore" instead of just "store"
- Breaking change (API): Remove `svgCanvas.rasterExport` fourth (callback) argument, collapsing fifth (options) to fourth
- Breaking change (API): Remove `svgCanvas.exportPDF` third (callback) argument
- Breaking change (API): `editor/contextmenu.js` `add` now throws instead of giving a console error only upon detecting a bad menuitem or preexisting context menu
- Breaking change (API): Remove `svgCanvas.embedImage` second (callback) argument
- Breaking change (API): Make `getHelpXML` a class instead of instance method of `RGBColor`
- Breaking change (internal API): Refactor `dbox` (and `alert`/`confirm`/`process`/`prompt`/`select`) to avoid a callback argument in favor of return a Promise
- Fix: Avoid running in extension `langReady` multiple times or serially
- Enhancement (API): Add svgCanvas.runExtension to run just one extension and add `nameFilter` callback to `runExtensions`
- Enhancement (API): Supply `$` (our wrapped jQuery) to extensions so can use its plugins, e.g., dbox with its `alert`
- Enhancement: Use alert dialog in place of `alert` in webappfind
- Enhancement: `editor.ready` now returns a Promise resolving when all callbacks have resolved
- Enhancement: Allow `noAlert` option as part of second argument to `loadSvgString` (and `loadFromURL` and `loadFromDataURI`) to avoid UI alert (and trigger promise rejection)
- Enhancement: Make `dbox` as a separate module for alert, prompt, etc. dialogs
- Refactoring: Internal `PaintBox` as class; other misc. tweaks; no bitwise in canvg
- Linting (ESLint): Further linting changes (for editor); rename `.eslintrc` -> `.eslintrc.json` per recommendation
- Optimization: Recompress images (imageoptim-cli updated)
- npm: Update devDeps
- npm: Bump to 4.0.0

editor/extensions/imagelib/index.js

@@ -32,7 +32,8 @@ $('a').click(function () {
         data = canvas.toDataURL();
       } catch (err) {
         // This fails in Firefox with `file:///` URLs :(
-        alert('Data URL conversion failed: ' + err);
+        // Todo: This could use a generic alert library instead
+        alert('Data URL conversion failed: ' + err); // eslint-disable-line no-alert
         data = '';
       }
       post({href, data});

editor/extensions/imagelib/openclipart.js

@@ -6,6 +6,8 @@ manipulation($, jml);
 
 const baseAPIURL = 'https://openclipart.org/search/json/';
 
+const jsVoid = 'javascript: void(0);'; // eslint-disable-line no-script-url
+
 /**
  * Shows results after query submission.
  * @param {string} url
@@ -18,7 +20,7 @@ async function processResults (url) {
    */
   function queryLink (query) {
     return ['a', {
-      href: 'javascript: void(0);',
+      href: jsVoid,
       dataset: {value: query},
       $on: {click (e) {
         e.preventDefault();
@@ -34,7 +36,8 @@ async function processResults (url) {
   // console.log('json', json);
 
   if (!json || json.msg !== 'success') {
-    alert('There was a problem downloading the results');
+    // Todo: This could use a generic alert library instead
+    alert('There was a problem downloading the results'); // eslint-disable-line no-alert
     return;
   }
   const {payload, info: {
@@ -82,8 +85,8 @@ async function processResults (url) {
         ['button', {style: 'margin-right: 8px; border: 2px solid black;', dataset: {id, value: svgURL}, $on: {
           async click (e) {
             e.preventDefault();
-            const {value: svgURL, id} = this.dataset;
-            // console.log('this', id, svgURL);
+            const {value: svgurl} = this.dataset;
+            // console.log('this', id, svgurl);
             const post = (message) => {
               // Todo: Make origin customizable as set by opening window
               // Todo: If dropping IE9, avoid stringifying
@@ -95,13 +98,13 @@ async function processResults (url) {
             // Send metadata (also indicates file is about to be sent)
             post({
               name: title,
-              id: svgURL
+              id: svgurl
             });
-            const result = await fetch(svgURL);
+            const result = await fetch(svgurl);
             const svg = await result.text();
-            // console.log('url and svg', svgURL, svg);
+            // console.log('url and svg', svgurl, svg);
             post({
-              href: svgURL,
+              href: svgurl,
               data: svg
             });
           }
@@ -117,7 +120,7 @@ async function processResults (url) {
         ['span', [
           '(ID: ',
           ['a', {
-            href: 'javascript: void(0);',
+            href: jsVoid,
             dataset: {value: id},
             $on: {
               click (e) {
@@ -172,7 +175,7 @@ async function processResults (url) {
       ? ''
       : ['span', [
         ['a', {
-          href: 'javascript: void(0);',
+          href: jsVoid,
           $on: {
             click (e) {
               e.preventDefault();
@@ -188,7 +191,7 @@ async function processResults (url) {
       ? ''
       : ['span', [
         ['a', {
-          href: 'javascript: void(0);',
+          href: jsVoid,
           $on: {
             click (e) {
               e.preventDefault();
@@ -204,7 +207,7 @@ async function processResults (url) {
       ? ''
       : ['span', [
         ['a', {
-          href: 'javascript: void(0);',
+          href: jsVoid,
           $on: {
             click (e) {
               e.preventDefault();
@@ -220,7 +223,7 @@ async function processResults (url) {
       ? ''
       : ['span', [
         ['a', {
-          href: 'javascript: void(0);',
+          href: jsVoid,
           $on: {
             click (e) {
               e.preventDefault();