- Breaking change: loadSvgString now returns a Promise rather than accepting a callback

- Breaking change: Treat callbacks to `editor.ready` as Promises, only resolving after all resolve
- Breaking change: Make `editor.runCallbacks` return a `Promise` which resolves upon all callbacks resolving
- Breaking change: Require `npx` (used with `babel-node`) to allow Node files
  for HTML building and JSDoc type checking to be expressed as ESM.
- Breaking change: `addExtension` now throws upon a repeated attempt to add an already-added extension
- Breaking change (storage preference cookies): Namespace the cookie as "svgeditstore" instead of just "store"
- Breaking change (API): Remove `svgCanvas.rasterExport` fourth (callback) argument, collapsing fifth (options) to fourth
- Breaking change (API): Remove `svgCanvas.exportPDF` third (callback) argument
- Breaking change (API): `editor/contextmenu.js` `add` now throws instead of giving a console error only upon detecting a bad menuitem or preexisting context menu
- Breaking change (API): Remove `svgCanvas.embedImage` second (callback) argument
- Breaking change (API): Make `getHelpXML` a class instead of instance method of `RGBColor`
- Breaking change (internal API): Refactor `dbox` (and `alert`/`confirm`/`process`/`prompt`/`select`) to avoid a callback argument in favor of return a Promise
- Fix: Avoid running in extension `langReady` multiple times or serially
- Enhancement (API): Add svgCanvas.runExtension to run just one extension and add `nameFilter` callback to `runExtensions`
- Enhancement (API): Supply `$` (our wrapped jQuery) to extensions so can use its plugins, e.g., dbox with its `alert`
- Enhancement: Use alert dialog in place of `alert` in webappfind
- Enhancement: `editor.ready` now returns a Promise resolving when all callbacks have resolved
- Enhancement: Allow `noAlert` option as part of second argument to `loadSvgString` (and `loadFromURL` and `loadFromDataURI`) to avoid UI alert (and trigger promise rejection)
- Enhancement: Make `dbox` as a separate module for alert, prompt, etc. dialogs
- Refactoring: Internal `PaintBox` as class; other misc. tweaks; no bitwise in canvg
- Linting (ESLint): Further linting changes (for editor); rename `.eslintrc` -> `.eslintrc.json` per recommendation
- Optimization: Recompress images (imageoptim-cli updated)
- npm: Update devDeps
- npm: Bump to 4.0.0

editor/jspdf/jspdf.plugin.svgToPdf.js

@@ -68,8 +68,8 @@ const getLinesOptionsOfPoly = function (node) {
     }
   }
   if (nums.length < 4) {
-    console.log('invalid points attribute:', node);
-    return;
+    console.log('invalid points attribute:', node); // eslint-disable-line no-console
+    return undefined;
   }
   const [x, y] = nums, lines = [];
   for (let i = 2; i < nums.length; i += 2) {
@@ -171,7 +171,7 @@ const svgElementToPdf = function (element, pdf, options) {
       removeAttributes(node, pdfSvgAttr.circle);
       break;
     case 'polygon':
-    case 'polyline':
+    case 'polyline': {
       const linesOptions = getLinesOptionsOfPoly(node);
       if (linesOptions) {
         pdf.lines(
@@ -186,7 +186,7 @@ const svgElementToPdf = function (element, pdf, options) {
       removeAttributes(node, pdfSvgAttr.polygon);
       break;
     // TODO: path
-    case 'text':
+    } case 'text': {
       if (node.hasAttribute('font-family')) {
         switch ((node.getAttribute('font-family') || '').toLowerCase()) {
         case 'serif': pdf.setFont('times'); break;
@@ -219,19 +219,24 @@ const svgElementToPdf = function (element, pdf, options) {
         ? parseInt(node.getAttribute('font-size'))
         : 16;
 
-      const getWidth = (node) => {
+      /**
+       *
+       * @param {Element} elem
+       * @returns {Float}
+       */
+      const getWidth = (elem) => {
         let box;
         try {
-          box = node.getBBox(); // Firefox on MacOS will raise error here
+          box = elem.getBBox(); // Firefox on MacOS will raise error here
         } catch (err) {
           // copy and append to body so that getBBox is available
-          const nodeCopy = node.cloneNode(true);
-          const svg = node.ownerSVGElement.cloneNode(false);
+          const nodeCopy = elem.cloneNode(true);
+          const svg = elem.ownerSVGElement.cloneNode(false);
           svg.appendChild(nodeCopy);
           document.body.appendChild(svg);
           try {
             box = nodeCopy.getBBox();
-          } catch (err) {
+          } catch (error) {
             box = {width: 0};
           }
           document.body.removeChild(svg);
@@ -259,9 +264,9 @@ const svgElementToPdf = function (element, pdf, options) {
       removeAttributes(node, pdfSvgAttr.text);
       break;
     // TODO: image
-    default:
+    } default:
       if (remove) {
-        console.log("can't translate to pdf:", node);
+        console.log("can't translate to pdf:", node); // eslint-disable-line no-console
         node.remove();
       }
     }