- Breaking change: loadSvgString now returns a Promise rather than accepting a callback

- Breaking change: Treat callbacks to `editor.ready` as Promises, only resolving after all resolve
- Breaking change: Make `editor.runCallbacks` return a `Promise` which resolves upon all callbacks resolving
- Breaking change: Require `npx` (used with `babel-node`) to allow Node files
  for HTML building and JSDoc type checking to be expressed as ESM.
- Breaking change: `addExtension` now throws upon a repeated attempt to add an already-added extension
- Breaking change (storage preference cookies): Namespace the cookie as "svgeditstore" instead of just "store"
- Breaking change (API): Remove `svgCanvas.rasterExport` fourth (callback) argument, collapsing fifth (options) to fourth
- Breaking change (API): Remove `svgCanvas.exportPDF` third (callback) argument
- Breaking change (API): `editor/contextmenu.js` `add` now throws instead of giving a console error only upon detecting a bad menuitem or preexisting context menu
- Breaking change (API): Remove `svgCanvas.embedImage` second (callback) argument
- Breaking change (API): Make `getHelpXML` a class instead of instance method of `RGBColor`
- Breaking change (internal API): Refactor `dbox` (and `alert`/`confirm`/`process`/`prompt`/`select`) to avoid a callback argument in favor of return a Promise
- Fix: Avoid running in extension `langReady` multiple times or serially
- Enhancement (API): Add svgCanvas.runExtension to run just one extension and add `nameFilter` callback to `runExtensions`
- Enhancement (API): Supply `$` (our wrapped jQuery) to extensions so can use its plugins, e.g., dbox with its `alert`
- Enhancement: Use alert dialog in place of `alert` in webappfind
- Enhancement: `editor.ready` now returns a Promise resolving when all callbacks have resolved
- Enhancement: Allow `noAlert` option as part of second argument to `loadSvgString` (and `loadFromURL` and `loadFromDataURI`) to avoid UI alert (and trigger promise rejection)
- Enhancement: Make `dbox` as a separate module for alert, prompt, etc. dialogs
- Refactoring: Internal `PaintBox` as class; other misc. tweaks; no bitwise in canvg
- Linting (ESLint): Further linting changes (for editor); rename `.eslintrc` -> `.eslintrc.json` per recommendation
- Optimization: Recompress images (imageoptim-cli updated)
- npm: Update devDeps
- npm: Bump to 4.0.0

editor/spinbtn/jQuery.SpinButton.js

@@ -84,18 +84,20 @@ export default function jQueryPluginSpinButton ($) {
   /**
   * @callback module:jQuerySpinButton.StepCallback
   * @param {external:jQuery} thisArg Value of `this`
+  * @param {Float} i Value to adjust
+  * @returns {Float}
   */
   /**
   * @callback module:jQuerySpinButton.ValueCallback
-  * @param {external:jQuery} thisArg Value of `this`
-  * @param {Float} value Value that was changed
+  * @param {external:jQuery.fn.SpinButton} thisArg Spin Button; check its `value` to see how it was changed.
+  * @returns {undefined}
   */
   /**
    * @typedef {PlainObject} module:jQuerySpinButton.SpinButtonConfig
    * @property {Float} min Set lower limit
    * @property {Float} max Set upper limit.
    * @property {Float} step Set increment size.
-   * @property {module:jQuerySpinButton.StepCallback} stepfunc Custom function to run when changing a value; called with `this` of object and the value to adjust
+   * @property {module:jQuerySpinButton.StepCallback} stepfunc Custom function to run when changing a value; called with `this` of object and the value to adjust and returns a float.
    * @property {module:jQuerySpinButton.ValueCallback} callback Called after value adjusted (with `this` of object)
    * @property {Float} smallStep Set shift-click increment size.
    * @property {PlainObject} stateObj Object to allow passing in live-updating scale
@@ -115,6 +117,13 @@ export default function jQueryPluginSpinButton ($) {
   */
   $.fn.SpinButton = function (cfg) {
     cfg = cfg || {};
+
+    /**
+     *
+     * @param {Element} el
+     * @param {"offsetLeft"|"offsetTop"} prop
+     * @returns {Integer}
+     */
     function coord (el, prop) {
       const b = document.body;
 
@@ -169,7 +178,9 @@ export default function jQueryPluginSpinButton ($) {
         if (this.spinCfg.min !== null) { v = Math.max(v, this.spinCfg.min); }
         if (this.spinCfg.max !== null) { v = Math.min(v, this.spinCfg.max); }
         this.value = v;
-        if (typeof this.spinCfg.callback === 'function') { this.spinCfg.callback(this); }
+        if (typeof this.spinCfg.callback === 'function') {
+          this.spinCfg.callback(this);
+        }
       };
 
       $(this)
@@ -186,7 +197,8 @@ export default function jQueryPluginSpinButton ($) {
           const direction =
             (x > coord(el, 'offsetLeft') +
               el.offsetWidth * scale - this.spinCfg._btn_width)
-              ? ((y < coord(el, 'offsetTop') + height * scale) ? 1 : -1) : 0;
+              ? ((y < coord(el, 'offsetTop') + height * scale) ? 1 : -1)
+              : 0;
 
           if (direction !== this.spinCfg._direction) {
             // Style up/down buttons: