- Breaking change: loadSvgString now returns a Promise rather than accepting a callback

- Breaking change: Treat callbacks to `editor.ready` as Promises, only resolving after all resolve
- Breaking change: Make `editor.runCallbacks` return a `Promise` which resolves upon all callbacks resolving
- Breaking change: Require `npx` (used with `babel-node`) to allow Node files
  for HTML building and JSDoc type checking to be expressed as ESM.
- Breaking change: `addExtension` now throws upon a repeated attempt to add an already-added extension
- Breaking change (storage preference cookies): Namespace the cookie as "svgeditstore" instead of just "store"
- Breaking change (API): Remove `svgCanvas.rasterExport` fourth (callback) argument, collapsing fifth (options) to fourth
- Breaking change (API): Remove `svgCanvas.exportPDF` third (callback) argument
- Breaking change (API): `editor/contextmenu.js` `add` now throws instead of giving a console error only upon detecting a bad menuitem or preexisting context menu
- Breaking change (API): Remove `svgCanvas.embedImage` second (callback) argument
- Breaking change (API): Make `getHelpXML` a class instead of instance method of `RGBColor`
- Breaking change (internal API): Refactor `dbox` (and `alert`/`confirm`/`process`/`prompt`/`select`) to avoid a callback argument in favor of return a Promise
- Fix: Avoid running in extension `langReady` multiple times or serially
- Enhancement (API): Add svgCanvas.runExtension to run just one extension and add `nameFilter` callback to `runExtensions`
- Enhancement (API): Supply `$` (our wrapped jQuery) to extensions so can use its plugins, e.g., dbox with its `alert`
- Enhancement: Use alert dialog in place of `alert` in webappfind
- Enhancement: `editor.ready` now returns a Promise resolving when all callbacks have resolved
- Enhancement: Allow `noAlert` option as part of second argument to `loadSvgString` (and `loadFromURL` and `loadFromDataURI`) to avoid UI alert (and trigger promise rejection)
- Enhancement: Make `dbox` as a separate module for alert, prompt, etc. dialogs
- Refactoring: Internal `PaintBox` as class; other misc. tweaks; no bitwise in canvg
- Linting (ESLint): Further linting changes (for editor); rename `.eslintrc` -> `.eslintrc.json` per recommendation
- Optimization: Recompress images (imageoptim-cli updated)
- npm: Update devDeps
- npm: Bump to 4.0.0

test/contextmenu_test.js

@@ -30,14 +30,20 @@ QUnit.test('Test svgedit.contextmenu package', function (assert) {
 QUnit.test('Test svgedit.contextmenu does not add invalid menu item', function (assert) {
   assert.expect(3);
 
-  contextmenu.add({id: 'justanid'});
-  assert.ok(!contextmenu.hasCustomHandler('justanid'), 'menu item with just an id is invalid');
+  assert.throws(
+    () => contextmenu.add({id: 'justanid'}),
+    'menu item with just an id is invalid'
+  );
 
-  contextmenu.add({id: 'idandlabel', label: 'anicelabel'});
-  assert.ok(!contextmenu.hasCustomHandler('idandlabel'), 'menu item with just an id and label is invalid');
+  assert.throws(
+    () => contextmenu.add({id: 'idandlabel', label: 'anicelabel'}),
+    'menu item with just an id and label is invalid'
+  );
 
-  contextmenu.add({id: 'idandlabel', label: 'anicelabel', action: 'notafunction'});
-  assert.ok(!contextmenu.hasCustomHandler('idandlabel'), 'menu item with action that is not a function is invalid');
+  assert.throws(
+    () => contextmenu.add({id: 'idandlabel', label: 'anicelabel', action: 'notafunction'}),
+    'menu item with action that is not a function is invalid'
+  );
 });
 
 QUnit.test('Test svgedit.contextmenu adds valid menu item', function (assert) {
@@ -57,8 +63,11 @@ QUnit.test('Test svgedit.contextmenu rejects valid duplicate menu item id', func
   const validItem1 = {id: 'valid', label: 'anicelabel', action () { console.log('testing'); }};
   const validItem2 = {id: 'valid', label: 'anicelabel', action () { console.log('testingtwice'); }};
   contextmenu.add(validItem1);
-  contextmenu.add(validItem2);
 
-  assert.equal(contextmenu.getCustomHandler('valid'), validItem1.action, 'duplicate menu item is rejected.');
+  assert.throws(
+    () => contextmenu.add(validItem2),
+    'duplicate menu item is rejected.'
+  );
+
   tearDown();
 });

test/history_test.js

@@ -317,7 +317,7 @@ QUnit.test('Test MoveElementCommand', function (assert) {
 
   setUp();
 
-  let move = new history.MoveElementCommand(div3, div1, divparent);
+  let move = new hstory.MoveElementCommand(div3, div1, divparent);
   assert.ok(move.unapply);
   assert.ok(move.apply);
   assert.equal(typeof move.unapply, typeof function () { /* */ });

test/qunit/qunit-assert-close.js

@@ -10,7 +10,7 @@
  * @param {string} [message] Defaults to structured message
  * @returns {undefined}
  */
-function close (actual, expected, maxDifference, message) { // eslint-disable-line no-shadow
+function close (actual, expected, maxDifference, message) {
   const actualDiff = (actual === expected) ? 0 : Math.abs(actual - expected),
     result = actualDiff <= maxDifference;
   message = message || (actual + ' should be within ' + maxDifference + ' (inclusive) of ' + expected + (result ? '' : '. Actual: ' + actualDiff));
@@ -21,7 +21,7 @@ function close (actual, expected, maxDifference, message) { // eslint-disable-li
  * Checks that the first two arguments are equal, or are numbers close enough to be considered equal
  * based on a specified maximum allowable difference percentage.
  *
- * @example assert.close.percent(155, 150, 3.4);  // Difference is ~3.33%
+ * @example assert.close.percent(155, 150, 3.4); // Difference is ~3.33%
  *
  * @param {Float} actual
  * @param {Float} expected
@@ -70,7 +70,7 @@ function notClose (actual, expected, minDifference, message) {
  * Checks that the first two arguments are numbers with differences greater than the specified
  * minimum difference percentage.
  *
- * @example assert.notClose.percent(156, 150, 3.5);  // Difference is 4.0%
+ * @example assert.notClose.percent(156, 150, 3.5); // Difference is 4.0%
  *
  * @param {Float} actual
  * @param {Float} expected