github/svgedit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

- Fix (Accessibility): Avoid duplicate IDs

Browse Source
This commit is contained in:
Brett Zamir
2019-11-23 21:18:21 +08:00
parent 3736fddb7f
commit 34721f2351
10 changed files with 20 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
CHANGES.md
View File

@@ -1,5 +1,11 @@
# SVG-Edit CHANGES # SVG-Edit CHANGES
## ?
- Fix (Accessibility): Avoid duplicate IDs
- Testing: Switch to Cypress with code coverage for UI testing
- npm: Add peerDeps
## 5.1.0 ## 5.1.0
- Deprecated: Should now use `avoidClientSideDownload` in place of - Deprecated: Should now use `avoidClientSideDownload` in place of

3
dist/index-es.js vendored
View File

@@ -34385,7 +34385,7 @@ editor.init = function () {
var cur = curConfig[type === 'fill' ? 'initFill' : 'initStroke']; // set up gradients to be used for the buttons var cur = curConfig[type === 'fill' ? 'initFill' : 'initStroke']; // set up gradients to be used for the buttons
var svgdocbox = new DOMParser().parseFromString("<svg xmlns=\"http://www.w3.org/2000/svg\">\n <rect width=\"16.5\" height=\"16.5\"\n fill=\"#".concat(cur.color, "\" opacity=\"").concat(cur.opacity, "\"/>\n <defs><linearGradient id=\"gradbox_\"/></defs>\n </svg>"), 'text/xml'); var svgdocbox = new DOMParser().parseFromString("<svg xmlns=\"http://www.w3.org/2000/svg\">\n <rect width=\"16.5\" height=\"16.5\"\n fill=\"#".concat(cur.color, "\" opacity=\"").concat(cur.opacity, "\"/>\n <defs><linearGradient id=\"gradbox_").concat(PaintBox.ctr++, "\"/></defs>\n </svg>"), 'text/xml');
var docElem = svgdocbox.documentElement; var docElem = svgdocbox.documentElement;
docElem = $$b(container)[0].appendChild(document.importNode(docElem, true)); docElem = $$b(container)[0].appendChild(document.importNode(docElem, true));
docElem.setAttribute('width', 16.5); docElem.setAttribute('width', 16.5);
@@ -34521,6 +34521,7 @@ editor.init = function () {
return PaintBox; return PaintBox;
}(); }();
PaintBox.ctr = 0;
paintBox.fill = new PaintBox('#fill_color', 'fill'); paintBox.fill = new PaintBox('#fill_color', 'fill');
paintBox.stroke = new PaintBox('#stroke_color', 'stroke'); paintBox.stroke = new PaintBox('#stroke_color', 'stroke');
$$b('#stroke_width').val(curConfig.initStroke.width); $$b('#stroke_width').val(curConfig.initStroke.width);

2
dist/index-es.min.js vendored
View File

File diff suppressed because one or more lines are too long

2
dist/index-es.min.js.map vendored
View File

File diff suppressed because one or more lines are too long

3
dist/index-umd.js vendored
View File

@@ -34391,7 +34391,7 @@
var cur = curConfig[type === 'fill' ? 'initFill' : 'initStroke']; // set up gradients to be used for the buttons var cur = curConfig[type === 'fill' ? 'initFill' : 'initStroke']; // set up gradients to be used for the buttons
var svgdocbox = new DOMParser().parseFromString("<svg xmlns=\"http://www.w3.org/2000/svg\">\n <rect width=\"16.5\" height=\"16.5\"\n fill=\"#".concat(cur.color, "\" opacity=\"").concat(cur.opacity, "\"/>\n <defs><linearGradient id=\"gradbox_\"/></defs>\n </svg>"), 'text/xml'); var svgdocbox = new DOMParser().parseFromString("<svg xmlns=\"http://www.w3.org/2000/svg\">\n <rect width=\"16.5\" height=\"16.5\"\n fill=\"#".concat(cur.color, "\" opacity=\"").concat(cur.opacity, "\"/>\n <defs><linearGradient id=\"gradbox_").concat(PaintBox.ctr++, "\"/></defs>\n </svg>"), 'text/xml');
var docElem = svgdocbox.documentElement; var docElem = svgdocbox.documentElement;
docElem = $$b(container)[0].appendChild(document.importNode(docElem, true)); docElem = $$b(container)[0].appendChild(document.importNode(docElem, true));
docElem.setAttribute('width', 16.5); docElem.setAttribute('width', 16.5);
@@ -34527,6 +34527,7 @@
return PaintBox; return PaintBox;
}(); }();
PaintBox.ctr = 0;
paintBox.fill = new PaintBox('#fill_color', 'fill'); paintBox.fill = new PaintBox('#fill_color', 'fill');
paintBox.stroke = new PaintBox('#stroke_color', 'stroke'); paintBox.stroke = new PaintBox('#stroke_color', 'stroke');
$$b('#stroke_width').val(curConfig.initStroke.width); $$b('#stroke_width').val(curConfig.initStroke.width);

2
dist/index-umd.min.js vendored
View File

File diff suppressed because one or more lines are too long

2
dist/index-umd.min.js.map vendored
View File

File diff suppressed because one or more lines are too long

3
editor/svg-editor.js
View File

@@ -5057,7 +5057,7 @@ editor.init = function () {
`<svg xmlns="http://www.w3.org/2000/svg"> `<svg xmlns="http://www.w3.org/2000/svg">
<rect width="16.5" height="16.5" <rect width="16.5" height="16.5"
fill="#${cur.color}" opacity="${cur.opacity}"/> fill="#${cur.color}" opacity="${cur.opacity}"/>
<defs><linearGradient id="gradbox_"/></defs> <defs><linearGradient id="gradbox_${PaintBox.ctr++}"/></defs>
</svg>`, </svg>`,
'text/xml' 'text/xml'
); );
@@ -5173,6 +5173,7 @@ editor.init = function () {
} }
} }
} }
PaintBox.ctr = 0;
paintBox.fill = new PaintBox('#fill_color', 'fill'); paintBox.fill = new PaintBox('#fill_color', 'fill');
paintBox.stroke = new PaintBox('#stroke_color', 'stroke'); paintBox.stroke = new PaintBox('#stroke_color', 'stroke');

3
editor/xdomain-svgedit-config-iife.js
View File

@@ -34388,7 +34388,7 @@
var cur = curConfig[type === 'fill' ? 'initFill' : 'initStroke']; // set up gradients to be used for the buttons var cur = curConfig[type === 'fill' ? 'initFill' : 'initStroke']; // set up gradients to be used for the buttons
var svgdocbox = new DOMParser().parseFromString("<svg xmlns=\"http://www.w3.org/2000/svg\">\n <rect width=\"16.5\" height=\"16.5\"\n fill=\"#".concat(cur.color, "\" opacity=\"").concat(cur.opacity, "\"/>\n <defs><linearGradient id=\"gradbox_\"/></defs>\n </svg>"), 'text/xml'); var svgdocbox = new DOMParser().parseFromString("<svg xmlns=\"http://www.w3.org/2000/svg\">\n <rect width=\"16.5\" height=\"16.5\"\n fill=\"#".concat(cur.color, "\" opacity=\"").concat(cur.opacity, "\"/>\n <defs><linearGradient id=\"gradbox_").concat(PaintBox.ctr++, "\"/></defs>\n </svg>"), 'text/xml');
var docElem = svgdocbox.documentElement; var docElem = svgdocbox.documentElement;
docElem = $$b(container)[0].appendChild(document.importNode(docElem, true)); docElem = $$b(container)[0].appendChild(document.importNode(docElem, true));
docElem.setAttribute('width', 16.5); docElem.setAttribute('width', 16.5);
@@ -34524,6 +34524,7 @@
return PaintBox; return PaintBox;
}(); }();
PaintBox.ctr = 0;
paintBox.fill = new PaintBox('#fill_color', 'fill'); paintBox.fill = new PaintBox('#fill_color', 'fill');
paintBox.stroke = new PaintBox('#stroke_color', 'stroke'); paintBox.stroke = new PaintBox('#stroke_color', 'stroke');
$$b('#stroke_width').val(curConfig.initStroke.width); $$b('#stroke_width').val(curConfig.initStroke.width);

3
svgedit-config-iife.js
View File

@@ -34388,7 +34388,7 @@
var cur = curConfig[type === 'fill' ? 'initFill' : 'initStroke']; // set up gradients to be used for the buttons var cur = curConfig[type === 'fill' ? 'initFill' : 'initStroke']; // set up gradients to be used for the buttons
var svgdocbox = new DOMParser().parseFromString("<svg xmlns=\"http://www.w3.org/2000/svg\">\n <rect width=\"16.5\" height=\"16.5\"\n fill=\"#".concat(cur.color, "\" opacity=\"").concat(cur.opacity, "\"/>\n <defs><linearGradient id=\"gradbox_\"/></defs>\n </svg>"), 'text/xml'); var svgdocbox = new DOMParser().parseFromString("<svg xmlns=\"http://www.w3.org/2000/svg\">\n <rect width=\"16.5\" height=\"16.5\"\n fill=\"#".concat(cur.color, "\" opacity=\"").concat(cur.opacity, "\"/>\n <defs><linearGradient id=\"gradbox_").concat(PaintBox.ctr++, "\"/></defs>\n </svg>"), 'text/xml');
var docElem = svgdocbox.documentElement; var docElem = svgdocbox.documentElement;
docElem = $$b(container)[0].appendChild(document.importNode(docElem, true)); docElem = $$b(container)[0].appendChild(document.importNode(docElem, true));
docElem.setAttribute('width', 16.5); docElem.setAttribute('width', 16.5);
@@ -34524,6 +34524,7 @@
return PaintBox; return PaintBox;
}(); }();
PaintBox.ctr = 0;
paintBox.fill = new PaintBox('#fill_color', 'fill'); paintBox.fill = new PaintBox('#fill_color', 'fill');
paintBox.stroke = new PaintBox('#stroke_color', 'stroke'); paintBox.stroke = new PaintBox('#stroke_color', 'stroke');
$$b('#stroke_width').val(curConfig.initStroke.width); $$b('#stroke_width').val(curConfig.initStroke.width);