- Refactoring: Make dialog OK button retrievable locale-independently (for testing)

- Testing: Avoid testing being locale-dependent; approve storage (and set locale to English) before each test
This commit is contained in:
Brett Zamir
2019-03-16 19:29:14 +08:00
parent d1f09a19ad
commit 6d9130b1fb
14 changed files with 28 additions and 39 deletions

2
dist/index-es.js vendored
View File

@@ -9640,7 +9640,7 @@ function jQueryPluginDBox($) {
function dbox(type, msg, defaultVal, opts, changeListener, checkbox) {
dialogContent.html('<p>' + msg.replace(/\n/g, '</p><p>') + '</p>').toggleClass('prompt', type === 'prompt');
btnHolder.empty();
var ok = $('<input type="button" value="' + strings.ok + '">').appendTo(btnHolder);
var ok = $('<input type="button" data-ok="" value="' + strings.ok + '">').appendTo(btnHolder);
return new Promise(function (resolve, reject) {
// eslint-disable-line promise/avoid-new
if (type !== 'alert') {

File diff suppressed because one or more lines are too long

File diff suppressed because one or more lines are too long

2
dist/index-umd.js vendored
View File

@@ -9646,7 +9646,7 @@
function dbox(type, msg, defaultVal, opts, changeListener, checkbox) {
dialogContent.html('<p>' + msg.replace(/\n/g, '</p><p>') + '</p>').toggleClass('prompt', type === 'prompt');
btnHolder.empty();
var ok = $('<input type="button" value="' + strings.ok + '">').appendTo(btnHolder);
var ok = $('<input type="button" data-ok="" value="' + strings.ok + '">').appendTo(btnHolder);
return new Promise(function (resolve, reject) {
// eslint-disable-line promise/avoid-new
if (type !== 'alert') {

File diff suppressed because one or more lines are too long

File diff suppressed because one or more lines are too long

View File

@@ -2673,7 +2673,7 @@ var SvgCanvas = (function () {
function dbox(type, msg, defaultVal, opts, changeListener, checkbox) {
dialogContent.html('<p>' + msg.replace(/\n/g, '</p><p>') + '</p>').toggleClass('prompt', type === 'prompt');
btnHolder.empty();
var ok = $('<input type="button" value="' + strings.ok + '">').appendTo(btnHolder);
var ok = $('<input type="button" data-ok="" value="' + strings.ok + '">').appendTo(btnHolder);
return new Promise(function (resolve, reject) {
// eslint-disable-line promise/avoid-new
if (type !== 'alert') {

File diff suppressed because one or more lines are too long

File diff suppressed because one or more lines are too long