github/svgedit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

- Docs (CHANGES)

Browse Source 
- Docs: Add "known regression" as possible commit prefix
This commit is contained in:
Brett Zamir
2018-09-22 10:12:11 +08:00
parent fbffc86503
commit 72b0cee994
2 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
CHANGES.md
View File

@@ -1,5 +1,11 @@
# ? # ?
- Security fix (minor): For embedded API, avoid chance for arbitrary
property setting (though this was only for trusted origins anyways)
- Security fix (minor): For embedded API example, copy params to iframe
source without XSS risk (though params should already be XML-safe
given `encodeURIComponent` and lack of a single quote attribute
context)
- Known regression for 3.\*: Image libraries - Known regression for 3.\*: Image libraries
[broken](https://github.com/SVG-Edit/svgedit/issues/274) [broken](https://github.com/SVG-Edit/svgedit/issues/274)
- Breaking change (minor): Change export to check `exportWindowName` - Breaking change (minor): Change export to check `exportWindowName`
@@ -9,6 +15,7 @@
PDF as export (#273 @cuixiping); fixes #124 and #254 PDF as export (#273 @cuixiping); fixes #124 and #254
- Fix: Ensure all apostrophes are escaped for `toXml` utility - Fix: Ensure all apostrophes are escaped for `toXml` utility
- Fix: Avoid error if `URL` is not defined - Fix: Avoid error if `URL` is not defined
- Fix (jPicker): Avoid setting `Math.precision` pseudo-global
- Fix (jPicker): Precision argument had not been passed in previously - Fix (jPicker): Precision argument had not been passed in previously
- Fix (image import): Put src after onload to avoid missing event; - Fix (image import): Put src after onload to avoid missing event;
check other width/height properties in case offset is 0; fixes #278 check other width/height properties in case offset is 0; fixes #278
@@ -18,10 +25,15 @@
- Fix (Star extension): Minor: Avoid erring if `inradius` is `NaN` - Fix (Star extension): Minor: Avoid erring if `inradius` is `NaN`
- Refactoring: Avoid passing unused arguments, setting unused variables, - Refactoring: Avoid passing unused arguments, setting unused variables,
and making unnecessary checks; avoid useless call to `createSVGMatrix` and making unnecessary checks; avoid useless call to `createSVGMatrix`
- Refactoring: Avoid useless assignment (courtesty lgtm)
- Refactoring: Destructuring, ellipsis
- Refactoring (jPicker): Use ES6 templates; avoid unnecessary check
- Linting (LGTM): Add `lgtm.yml` file (still some remaining items flagged - Linting (LGTM): Add `lgtm.yml` file (still some remaining items flagged
but hoping for in-code flagging) but hoping for in-code flagging)
- Linting (LGTM): Flag origin-checked item as safe
- Linting (ESLint): Consistent spacing; new "standard" - Linting (ESLint): Consistent spacing; new "standard"
- Docs: Contributing file - Docs: Contributing file
- Docs (JSDoc): Missing return value
- Build: Switch to `terser` plugin with `uglify` plugin not - Build: Switch to `terser` plugin with `uglify` plugin not
supporting ES6+-capable minifier supporting ES6+-capable minifier
- npm: Update devDeps - npm: Update devDeps

1
docs/Contributing.md
View File

@@ -3,6 +3,7 @@
1. Prefix every change in the commit with one of the following types (and 1. Prefix every change in the commit with one of the following types (and
sort into this order): sort into this order):
- `Security fix: ` - `Security fix: `
- `Known regression: `
- `Breaking change: ` - `Breaking change: `
- `Fix: ` - `Fix: `
- `Fix (<component>): ` Component may be an extension, locale, etc. - `Fix (<component>): ` Component may be an extension, locale, etc.